Skip to content
This repository has been archived by the owner on Sep 20, 2019. It is now read-only.

Destroying scope should only remove its own defaults #346

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Destroying scope should only remove its own defaults #346

wants to merge 8 commits into from

Conversation

eugenehuangsg
Copy link
Contributor

Dynamically instantiated maps's defaults are removed when other maps are removed. eg. using ng-if to toggle displaying of different tabs.

@eugenehuangsg eugenehuangsg force-pushed the master branch 2 times, most recently from e1942df to 1796afa Compare August 7, 2017 04:37
@eugenehuangsg
Copy link
Contributor Author

eugenehuangsg commented Aug 7, 2017 •
edited
Loading

Similar implementation to #322

npm test runs well locally. Build error is probably due to one of the package.json dependencies. I'm still unable to isolate which dependencies is causing the problem. #347

bfriedmann71 pushed a commit to BlueWaterSatellite/ui-leaflet that referenced this pull request Oct 16, 2017
Same implementation as angular-ui#346
be1b65c
@elesdoar
Copy link
Contributor

Please check this commit, fee0175,

all efforts will be focused on the version for Leaflet 1.x

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eugenehuangsg @elesdoar