Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIANXKE-407: Add pre-commit configuration and pipeline checks #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bernhard-hagmann
Copy link
Contributor

@bernhard-hagmann bernhard-hagmann commented Oct 25, 2024

Builds on #12

  • Adds pre-commit configuration and pipeline checks
  • Re-formats everything

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.15%. Comparing base (358ccfb) to head (9d91684).

Files with missing lines Patch % Lines
django_cleanhtmlfield/fields.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   63.80%   64.15%   +0.34%     
==========================================
  Files           2        2              
  Lines         105      106       +1     
==========================================
+ Hits           67       68       +1     
  Misses         38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bernhard-hagmann bernhard-hagmann marked this pull request as ready for review October 25, 2024 10:16
@bernhard-hagmann bernhard-hagmann changed the title Sianxke 407 SIANXKE-407: Add pre-commit configuration and pipeline checks Oct 25, 2024
@@ -167,7 +168,8 @@ def clean_html(html, strip_unsafe=False):
elif attr == "href":
tag[attr] = clean_hrefs(tag[attr])

except:
except Exception as e:
logger.debug(e, exc_info=True)
pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 pass can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants