Testing #158
+374
−152
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| /* | ||
| * Copyright (C) 2020 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.android.samples.webviewdemo | ||
| import android.content.Context | ||
| import android.os.Handler | ||
| import android.os.Looper | ||
| import android.webkit.WebView | ||
| import androidx.test.core.app.ApplicationProvider | ||
| import androidx.test.espresso.web.assertion.WebViewAssertions.webMatches | ||
| import androidx.test.espresso.web.model.Atoms.castOrDie | ||
| import androidx.test.espresso.web.model.Atoms.script | ||
| import androidx.test.espresso.web.sugar.Web.onWebView | ||
| import androidx.test.espresso.web.webdriver.DriverAtoms.findElement | ||
| import androidx.test.espresso.web.webdriver.DriverAtoms.getText | ||
| import androidx.test.espresso.web.webdriver.DriverAtoms.webClick | ||
| import androidx.test.espresso.web.webdriver.Locator | ||
| import androidx.test.ext.junit.runners.AndroidJUnit4 | ||
| import androidx.test.rule.ActivityTestRule | ||
| import junit.framework.Assert.assertEquals | ||
| import junit.framework.Assert.assertTrue | ||
| import org.hamcrest.CoreMatchers.`is` | ||
| import org.hamcrest.CoreMatchers.containsString | ||
| import org.junit.Rule | ||
| import org.junit.Test | ||
| import org.junit.runner.RunWith | ||
|
|
||
|
|
||
| /** | ||
| * Launch, interact, and verify conditions in an activity that has a WebView instance. | ||
| */ | ||
| @RunWith(AndroidJUnit4::class) | ||
|
|
||
|
|
||
| class MainActivityTest { | ||
|
|
||
| val context = ApplicationProvider.getApplicationContext<Context>() | ||
|
|
||
| @Rule @JvmField | ||
| val mainActivityRule = ActivityTestRule(MainActivity::class.java) | ||
| fun afterActivityLaunched() { | ||
| // Technically we do not need to do this - MainActivity has javascript turned on. | ||
| // Other WebViews in your app may have javascript turned off, however since the only way | ||
| // to automate WebViews is through javascript, it must be enabled. | ||
| onWebView().forceJavascriptEnabled() | ||
| } | ||
|
|
||
| // Test to check that the drop down menu behaves as expected | ||
| @Test | ||
| fun dropDownMenu_SanFran() { | ||
| mainActivityRule.getActivity() | ||
| onWebView() | ||
| .withElement(findElement(Locator.ID, "location")) | ||
| .perform(webClick()) // Similar to perform(click()) | ||
| .withElement(findElement(Locator.ID, "SF")) | ||
| .perform(webClick()) // Similar to perform(click()) | ||
| .withElement(findElement(Locator.ID, "title")) | ||
| .check(webMatches(getText(), containsString("San Francisco"))) | ||
| } | ||
|
|
||
| // Test for checking createJsObject | ||
| @Test | ||
| fun jsObjectIsInjectedAndContainsPostMessage() { | ||
| mainActivityRule.getActivity() | ||
| onWebView() | ||
| .check( | ||
| webMatches( | ||
| script("return jsObject && jsObject.postMessage != null;", castOrDie(Boolean::class.javaObjectType)), | ||
| `is`(true) | ||
| ) | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun valueInCallback_compareValueInput_returnsTrue(){ | ||
| mainActivityRule.getActivity() | ||
| // Setup | ||
| val jsObjName = "jsObject" | ||
| val allowedOriginRules = setOf<String>("https://example.com") | ||
| val message = "hello" | ||
| // Get a handler that can be used to post to the main thread | ||
| val mainHandler = Handler (Looper.getMainLooper()); | ||
| val myRunnable = Runnable() { | ||
| val webView = WebView(context) | ||
| // Create JsObject | ||
| createJsObject( | ||
| webView, | ||
| jsObjName, | ||
| allowedOriginRules | ||
| ) { message -> //save message; call .set() | ||
| } | ||
| run() { | ||
|
There was a problem hiding this comment. All this should be inside the runnable's "run()" method. nit: there should be a way to rewrite this to be more like a lambda style: // This is how it would look in Java
mainHandler.post(() -> {
WebView webView = WebView(context);
createJsObject(webView, jsObjName, allowedOriginRules, () -> {
// ...
});
// ...
});There was a problem hiding this comment. Ok, I will move that and make the change to a lambda style. |
||
| //Inject JsObject into Html | ||
| webView.loadDataWithBaseURL("https://example.com","<html></html>", | ||
| "text/html", "UTF-8","https://example.com") | ||
|
There was a problem hiding this comment.
|
||
| //Call js code to invoke callback | ||
| webView.evaluateJavascript("${jsObjName}.postMessage(${message})", null) | ||
| } | ||
| } | ||
| mainHandler.post(myRunnable) | ||
| // evaluate what comes out -> it should be hello | ||
| // *Note: //.get() is a place holder | ||
| assertEquals("hello" | ||
| , "//.get()" | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| // Checks that postMessage runs on the UI thread | ||
| fun checkingThreadCallbackRunsOn() { | ||
| mainActivityRule.getActivity() | ||
| // Setup | ||
| val jsObjName = "jsObject" | ||
| val allowedOriginRules = setOf<String>("https://example.com") | ||
| val message = "hello" | ||
| // Get a handler that can be used to post to the main thread | ||
| val mainHandler = Handler (Looper.getMainLooper()) | ||
| // Start Interacting with webView on UI thread | ||
| val myRunnable = Runnable() { | ||
| run() { | ||
| val webView = WebView(context) | ||
| // Create JsObject | ||
| createJsObject( | ||
| webView, | ||
| jsObjName, | ||
| allowedOriginRules | ||
| ) { message -> assertTrue(isUiThread()) } | ||
|
There was a problem hiding this comment. The next thing we'll want to do is to use a |
||
| //Inject JsObject into Html | ||
| webView.loadDataWithBaseURL("https://example.com","<html></html>", | ||
| "text/html", "UTF-8","https://example.com") | ||
| //Call js code to invoke callback | ||
| webView.evaluateJavascript("${jsObjName}.postMessage(${message})", null) | ||
| } | ||
| } | ||
| mainHandler.post(myRunnable) | ||
| } | ||
|
|
||
| /** | ||
| * Returns true if the current thread is the UI thread based on the | ||
| * Looper. | ||
| */ | ||
| private fun isUiThread(): Boolean { | ||
| return Looper.myLooper() == Looper.getMainLooper() | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
expectedMessagewould be better, not to be confused with the "actual message" (the one which comes from out of the callback)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. This made me think that we could also remove the message value in
checkingThreadCallbackRunsOn()as it has no purpose there. Because we removedmessage, I changed the value in thepostMessage()call to be the string hello instead of${message}.