Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated IntentsTestRule and applied ActivityScenarioRule instead. #380

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removed deprecated IntentsTestRule and applied ActivityScenarioRule instead. #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions ...Test/java/com/example/android/testing/espresso/IntentsBasicSample/DialerActivityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,17 @@
import android.content.Intent;
import android.net.Uri;
import android.os.Build;

import androidx.test.espresso.core.internal.deps.guava.collect.Iterables;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal classes should not be used. The former com.google.common.collect.Iterables import is correct

import androidx.test.espresso.intent.Intents;
import androidx.test.espresso.intent.rule.IntentsTestRule;
import androidx.test.ext.junit.rules.ActivityScenarioRule;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import androidx.test.filters.LargeTest;
import androidx.test.rule.ActivityTestRule;
import androidx.test.rule.GrantPermissionRule;
import com.google.common.collect.Iterables;

import org.junit.After;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
Expand All @@ -65,26 +69,28 @@ public class DialerActivityTest {
@Rule public GrantPermissionRule grantPermissionRule = GrantPermissionRule.grant("android.permission.CALL_PHONE");

/**
* A JUnit {@link Rule @Rule} to init and release Espresso Intents before and after each
* test run.
* <p>
* Rules are interceptors which are executed for each test method and will run before
* any of your setup code in the {@link Before @Before} method.
* <p>
* This rule is based on {@link ActivityTestRule} and will create and launch the activity
* for you and also expose the activity under test.
* Use {@link ActivityScenarioRule} to create and launch the activity under test, and close it
* after test completes. This is a replacement for {@link androidx.test.rule.ActivityTestRule}.
*/
@Rule
public IntentsTestRule<DialerActivity> mActivityRule = new IntentsTestRule<>(
public ActivityScenarioRule<DialerActivity> mActivityRule = new ActivityScenarioRule<>(
DialerActivity.class);

@Before
public void stubAllExternalIntents() {
// Initializes Intents and begins recording intents.
Intents.init();
// By default Espresso Intents does not stub any Intents. Stubbing needs to be setup before
// every test run. In this case all external Intents will be blocked.
intending(not(isInternal())).respondWith(new ActivityResult(Activity.RESULT_OK, null));
}

@After
public void tearDown() {
// Clears Intents state.
Intents.release();
}

@Test
public void typeNumber_ValidInput_InitiatesCall() {
// Types a phone number into the dialer edit text field and presses the call button.
Expand Down