ListDetailPaneScaffold #970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoczkowski
changed the base branch from
main
to
feature/navigation-suite-scaffold
|
One behavior issue I noticed: on a small screen (without list+detail showing together), if you tap on a topic, then navigate back, then tap on the same topic, the second tap doesn't navigate to the topic again: Screen_recording_20231017_173006.mp4 |
alexvanyo
reviewed
Oct 31, 2023
|
|
||
| fun followTopic(followedTopicId: String, followed: Boolean) { | ||
| viewModelScope.launch { | ||
| userDataRepository.setTopicIdFollowed(followedTopicId, followed) | ||
| } | ||
| } | ||
|
|
||
| fun onTopicClick(topicId: String) { | ||
| viewModelScope.launch { |
There was a problem hiding this comment.
There's no need for a launch here if we aren't calling a suspending function.
mmoczkowski
force-pushed
the
feature/navigation-suite-scaffold
branch
5 times, most recently
from
544e4db to
816a7b6
Compare
Change-Id: I13cca7db13411794e333d34f6edacf594586ef6d
mmoczkowski
force-pushed
the
feature/list-detail-pane-scaffold
branch
from
e9c64f3 to
dfff806
Compare
Change-Id: I4d77c84da8d18cec87f3b7a47603d62bfa9c790d
Change-Id: Ice4996331a1c44e5284839b2cdf2330c737361bf
Change-Id: I04c00490e97e0c41f5cc285df6a62014e6b12e47
Change-Id: I7e3ef3ca9bd01c436784bff0a33208abe3bc4703
Change-Id: I5ca91db033a658450144439e90ea4b880f57b7fd
Change-Id: Ic18da787dc58f2ef617149d97ad42e57da0e9a6a
Good catch. I found a few more bugs with navigation, both on phone and tablet. Repro steps:
Screen_recording_20240216_093654.mp4 |
|
Superseded by #1234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.