Update OfflineFirstTopicsRepositoryTest.kt #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the unit test to do meaning comparisons instead of just comparing two empty lists.
dturner
reviewed
Jan 7, 2025
...om/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt
Outdated
Show resolved
Hide resolved
dturner
reviewed
Jan 7, 2025
...om/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt
Outdated
Show resolved
Hide resolved
…/core/data/repository/OfflineFirstTopicsRepositoryTest.kt
…/core/data/repository/OfflineFirstTopicsRepositoryTest.kt
dturner
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the unit test to perform meaningful comparisons instead of simply comparing two empty lists.
In the unit test function
offlineFirstTopicsRepository_topics_stream_is_backed_by_topics_dao()Both
topicDao.getTopicEntities().first().map(TopicEntity::asExternalModel)andsubject.getTopics().first()return an empty list. This is becausesubject.syncWith(synchronizer)is not called beforehand.This unit test doesn't seem meaningful by just comparing two empty lists.
This PR adds a
subject.syncWith(synchronizer)call before retrieving the topic entities, so that lists with actual elements can be compared, to prove that offlineFirstTopicsRepository.getTopics() is based by topicDao.getTopicEntities().