Optimize google maven downloading #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
force-pushed
the
optimize-repos
branch
from
66c9fa1 to
be808b8
Compare
Goooler
changed the title
keyboardsurfer
approved these changes
Dec 9, 2024
|
@keyboardsurfer Have you actually tested this? Does it speed up downloading? It seems unnecessary to me. |
|
It will not speed up downloading per say, but rather prevent pinging Google's maven repository for dependencies that are available only on Maven Central. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request. Please include the following information.
What I have done and why
This will speed up dependencies downloading.
Do tests pass?
DemoDebugvariant:./gradlew testDemoDebug./gradlew --init-script gradle/init.gradle.kts spotlessApplyIs this your first pull request?
./tools/setup.sh