Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependency guard plugin #1035

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Add dependency guard plugin #1035

merged 6 commits into from
Nov 29, 2023

Conversation

jdkoren
Copy link
Contributor

@jdkoren jdkoren commented Nov 14, 2023

This adds the Dependency Guard gradle plugin and also commits baseline files for all *RuntimeClasspath configurations. Subsequent PRs will incorporate verification against these baselines in CI.

@jdkoren jdkoren requested a review from dturner November 14, 2023 19:23
JoseAlcerreca
JoseAlcerreca reviewed Nov 15, 2023
View reviewed changes
app/build.gradle.kts Outdated Show resolved Hide resolved
@SimonMarquis SimonMarquis mentioned this pull request Nov 16, 2023
Closed
3 tasks
SimonMarquis
SimonMarquis reviewed Nov 16, 2023
View reviewed changes
app/build.gradle.kts Outdated Show resolved Hide resolved
@jdkoren
Add dependency guard plugin
d5d5e35
@jdkoren
Fix alphabetic ordering
08a5796 
Change-Id: Ie0779252d969b80b8c8bcea6d58c13132e20c13c
@jdkoren
Remove empty file
e00f7b1 
Change-Id: Iaed9b4a68c45c1f52a2311d79b34569d20aaea62
@jdkoren
Only record prodReleaseRuntimeClasspath configuration
d15a203 
Change-Id: I129fc4839ac2b4d5624c91cd25b47efba8847f44
@jdkoren
Add dependencyGuard to AndroidApplicationConventionPlugin
392eaa3 
Change-Id: Ib695ca18512d0ccde4c67e101f09ebbff8897912
@jdkoren
Record dependencies for catalog releaseRuntimeClasspath
6297b74 
Change-Id: Id74cc7f372498c4cea3fe221230d6042bfc10478
SimonMarquis
SimonMarquis reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@SimonMarquis SimonMarquis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tunjid tunjid self-requested a review November 29, 2023 23:36
tunjid
tunjid approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@tunjid tunjid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdkoren jdkoren merged commit a7fb019 into android:main Nov 29, 2023
4 checks passed
@jdkoren jdkoren deleted the dep_guard branch November 29, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonMarquis SimonMarquis SimonMarquis left review comments

@tunjid tunjid tunjid approved these changes

@dturner dturner Awaiting requested review from dturner

@JoseAlcerreca JoseAlcerreca Awaiting requested review from JoseAlcerreca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdkoren @JoseAlcerreca @SimonMarquis @tunjid