Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for armv8 arch only devices #994

Merged
merged 4 commits into from
May 3, 2024
Merged

Support for armv8 arch only devices #994

merged 4 commits into from
May 3, 2024

Conversation

nfynt
Copy link
Contributor

@nfynt nfynt commented Apr 6, 2024

Recent pixel devices do not report armv7 arch support and only arm64-v8a. This causes benchmark test to exit early with message stating "Not an ARMv7 and not an X86 SSSE3 CPU !\n".

This update includes check for ANDROID_CPU_FAMILY_ARM64 along with subsequent cmake and gradle updates for running the test app.

Copy link

google-cla bot commented Apr 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@DanAlbert DanAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's actually quite a lot here that I think can be safely deleted, since Neon is available by default for a few NDK releases now. I'm not totally sure how much I can purge though, so I'll merge this and take a look at the cleanup separately.

For that matter, this whole sample would probably be more useful as a generic vectorization sample rather than specific to Neon, since there are also clang's arch-generic vector APIs, as well as SVE coming up with newer versions of armv8, and whatever rv64 has planned, but that's definitely out of scope for this PR :)

hello-neon/app/src/main/cpp/helloneon.c Outdated Show resolved Hide resolved
@DanAlbert DanAlbert enabled auto-merge (squash) April 22, 2024 19:11
@DanAlbert
Copy link
Member

I think you probably need to update

#if defined(HAVE_NEON) && defined(HAVE_NEON_X86)
?

@DanAlbert
Copy link
Member

Actually it was the CMakeLists.txt that needed updating. Pushed the fix to your branch.

@DanAlbert DanAlbert merged commit 1cb6518 into android:main May 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants