Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing File / OpenOptions constructors #69

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Add missing File / OpenOptions constructors #69

merged 5 commits into from
Jan 21, 2025

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Jan 18, 2025 •
edited
Loading

I've wanted at least one of these before, don't remember which one exactly 😄

Closes #56.

@jplatte
Copy link
Contributor Author

jplatte commented Jan 21, 2025

Updated the (non-tokio) create_new implementation to use the more verbose OpenOptions based 'spelling' of the same way of opening a file, this should fix the MSRV check.

Also added a commit to fix the new clippy lints that broke some other CI jobs.

@andrewhickman andrewhickman merged commit 5ba87e1 into andrewhickman:main Jan 21, 2025
6 checks passed
@andrewhickman
Copy link
Owner

Thanks!

@jplatte jplatte deleted the new-ctors branch January 21, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewhickman andrewhickman andrewhickman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File::create_new
2 participants
@jplatte @andrewhickman