-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat Suggestion methods api #291
Feat Suggestion methods api #291
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #291 +/- ##
============================================
+ Coverage 37.26% 37.35% +0.09%
- Complexity 387 393 +6
============================================
Files 107 110 +3
Lines 3118 3164 +46
Branches 186 187 +1
============================================
+ Hits 1162 1182 +20
- Misses 1834 1857 +23
- Partials 122 125 +3
|
# Conflicts: # bigbone/src/main/kotlin/social/bigbone/MastodonClient.kt
…into feature/suggestion_methods_api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work here! 😊
I have some suggestions that we should implement before moving forward with this PR.
bigbone/src/main/kotlin/social/bigbone/api/entity/Suggestion.kt
Outdated
Show resolved
Hide resolved
bigbone/src/main/kotlin/social/bigbone/api/entity/Suggestion.kt
Outdated
Show resolved
Hide resolved
bigbone/src/main/kotlin/social/bigbone/api/method/SuggestionMethods.kt
Outdated
Show resolved
Hide resolved
bigbone/src/test/kotlin/social/bigbone/api/method/SuggestionMethodsTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your updates! Just two minor optional changes left for me, but other than that this’d be fine by me. 😊
bigbone/src/main/kotlin/social/bigbone/api/method/SuggestionMethods.kt
Outdated
Show resolved
Hide resolved
bigbone/src/test/kotlin/social/bigbone/api/method/SuggestionMethodsTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Thanks for the work! 👍
Description
This PR implements the suggestions API so that users of this library can both fetch suggestions about users to follow and remove a suggested one.
This addresses #259
Type of Change
How Has This Been Tested?
Gradle check, gradle detect and gradle build
Mandatory Checklist
gradle check
and there were no errors reportedOther
Even both Rx counter parts and unit tests have been implemented
https://github.com/andregasser/bigbone/wiki/Mastodon-API-Coverage#methods needs to be updated after this has been merged!