fix: localisation cases when values are zeros (#74)

anct-cartographie-nationale · May 9, 2023 · d133282 · d133282
1 parent f68f393
commit d133282
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/transformer/fields/localisation/localisation.field.spec.ts b/src/transformer/fields/localisation/localisation.field.spec.ts
@@ -141,4 +141,14 @@ describe('localisation field', (): void => {
 
     expect(localisation).toStrictEqual<Localisation>(NO_LOCALISATION);
   });
+
+  it('should return null when coordinates have 0 as value', (): void => {
+    const source: DataSource = {
+      bf_latitude: '0',
+      bf_longitude: '0'
+    };
+    const localisation: Localisation = processLocalisation(source, STANDARD_MATCHING);
+
+    expect(localisation).toStrictEqual<Localisation>(NO_LOCALISATION);
+  });
 });
diff --git a/src/transformer/fields/localisation/localisation.field.ts b/src/transformer/fields/localisation/localisation.field.ts
@@ -8,6 +8,7 @@ type NoLocalisation = { noLocalisation: true } & null;
 export const NO_LOCALISATION: Localisation = null as NoLocalisation;
 
 const NO_LOCALISATION_COLONNE: string = '';
+const LOCALISATION_IS_ZERO_VALUES: number = NaN;
 const INVALID_NUMBERS_CHARS: RegExp = /[^\d.\s,-]+/gu;
 
 const isColonne = (colonneToTest: Partial<Colonne> & Partial<Dissociation>): colonneToTest is Colonne =>
@@ -33,8 +34,15 @@ const checkFormatLocalisation = (localisation: LocalisationToValidate): Localisa
 const localisationField = (source: DataSource, localisation: Dissociation & Partial<Colonne>): string | undefined =>
   (isColonne(localisation) ? source[localisation.colonne] : dissocier(source, localisation))?.toString().replace(',', '.');
 
-const validateLocalisationField = (localisationToValidate: LocalisationToValidate): Localisation =>
-  isValidLocalisation(localisationToValidate) ? localisationToValidate : checkFormatLocalisation(localisationToValidate);
+const validateLocalisationField = (localisationToValidate: LocalisationToValidate): Localisation => {
+  const localisationToValidateProbablyFalse: LocalisationToValidate =
+    localisationToValidate.latitude === 0 || localisationToValidate.longitude === 0
+      ? { latitude: LOCALISATION_IS_ZERO_VALUES, longitude: LOCALISATION_IS_ZERO_VALUES }
+      : localisationToValidate;
+  return isValidLocalisation(localisationToValidateProbablyFalse)
+    ? localisationToValidateProbablyFalse
+    : checkFormatLocalisation(localisationToValidateProbablyFalse);
+};
 
 const localisationFromMatching = (source: DataSource, matching: LieuxMediationNumeriqueMatching): LocalisationToValidate => ({
   latitude: parseFloat(localisationField(source, matching.latitude) ?? NO_LOCALISATION_COLONNE),