Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable package scan #3468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomersein
Copy link
Contributor

@tomersein tomersein commented Nov 20, 2024

Description

this PR enables the way to scan only using files cataloger without package cataloger
related to an older request I've submitted 3128 (link below)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have added unit tests that cover changed behavior
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

Signed-off-by: tomersein <[email protected]>
@spiffcs
Copy link
Contributor

spiffcs commented Dec 12, 2024

Linked PR from @wagoodman. This is the direction we probably want to go where we elevate the file catalogers to be selected in the same way package catalogers are being used.

#3505

TLDR we don't want to hide this and have it happen implicitly when finalTasks is 0.

@tomersein do you mind giving your feedback on 3505?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants