remove offline config for all platforms

amplitude · Jan 8, 2025 · 52c0e96 · 52c0e96
1 parent 1c7a8e7
commit 52c0e96
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 16 deletions.
diff --git a/android/src/main/kotlin/com/amplitude/amplitude_flutter/AmplitudeFlutterPlugin.kt b/android/src/main/kotlin/com/amplitude/amplitude_flutter/AmplitudeFlutterPlugin.kt
@@ -192,7 +192,6 @@ class AmplitudeFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
         call.argument<Boolean>("useAdvertisingIdForDeviceId")
             ?.let { configuration.useAdvertisingIdForDeviceId = it }
         call.argument<Boolean>("useAppSetIdForDeviceId")?.let { configuration.useAppSetIdForDeviceId = it }
-        call.argument<Boolean>("offline")?.let { configuration.offline = it }
 
         return configuration
     }

diff --git a/ios/Classes/SwiftAmplitudeFlutterPlugin.swift b/ios/Classes/SwiftAmplitudeFlutterPlugin.swift
@@ -176,9 +176,6 @@ import AmplitudeSwift
                 screenViews: screenViews
             )
         }
-        if let offline = args["offline"] as? Bool {
-            configuration.offline = offline
-        }
 
         return configuration
     }

diff --git a/lib/configuration.dart b/lib/configuration.dart
@@ -68,11 +68,6 @@ class Configuration {
   int minTimeBetweenSessionsMillis;
   /// Applicable to all platforms (iOS, Android, Web)
   ///
-  /// Whether the SDK connects to the network.
-  /// Check platform-specific documentation for more information.
-  bool offline;
-  /// Applicable to all platforms (iOS, Android, Web)
-  ///
   /// Configures tracking of extra properties.
   /// Check platform-specific documentation for more information.
   TrackingOptions trackingOptions;
@@ -193,7 +188,6 @@ class Configuration {
     this.identityStorage = 'cookie',
     this.userId,
     this.transport = 'fetch',
-    this.offline = false,
     this.fetchRemoteConfig = false,
   }): trackingOptions = trackingOptions ?? TrackingOptions(),
       cookieOptions = cookieOptions ?? CookieOptions() {
@@ -231,7 +225,6 @@ class Configuration {
       'sessionTimeout': minTimeBetweenSessionsMillis != Constants.minTimeBetweenSessionsMillisUnset ? minTimeBetweenSessionsMillis : Constants.minTimeBetweenSessionsMillisForWeb,
       'userId': userId,
       'transport': transport,
-      'offline': offline,
       'fetchRemoteConfig': fetchRemoteConfig,
       // This field doesn't belong to Configuration
       // Pass it for FlutterLibraryPlugin

diff --git a/test/amplitude_test.dart b/test/amplitude_test.dart
@@ -94,7 +94,6 @@ void main() {
     'sessionTimeout': 30 * 60 * 1000,
     'userId': null,
     'transport': 'fetch',
-    'offline': false,
     'fetchRemoteConfig': false,
     // This field doesn't belong to Configuration
     // Pass it for FlutterLibraryPlugin

diff --git a/test/configuration_test.dart b/test/configuration_test.dart
@@ -23,7 +23,6 @@ void main() {
       expect(config.serverZone, ServerZone.us);
       expect(config.serverUrl, isNull);
       expect(config.minTimeBetweenSessionsMillis, Constants.minTimeBetweenSessionsMillisUnset);
-      expect(config.offline, false);
       expect(config.trackingOptions, isA<TrackingOptions>());
       expect(config.defaultTracking, isA<DefaultTrackingOptions>());
       expect(config.enableCoppaControl, false);
@@ -56,7 +55,6 @@ void main() {
       expect(map['serverUrl'], isNull);
       expect(map['minTimeBetweenSessionsMillis'], Constants.minTimeBetweenSessionsMillisForMobile);
       expect(map['sessionTimeout'], Constants.minTimeBetweenSessionsMillisForWeb);
-      expect(map['offline'], false);
       expect(map.containsKey('trackingOptions'), true);
       expect(map.containsKey('defaultTracking'), true);
       expect(map['enableCoppaControl'], false);
@@ -90,7 +88,6 @@ void main() {
         serverZone: ServerZone.eu,
         serverUrl: 'https://custom.server.url',
         minTimeBetweenSessionsMillis: 2000,
-        offline: true,
         trackingOptions: TrackingOptions(language: false),
         defaultTracking: DefaultTrackingOptions(sessions: false),
         enableCoppaControl: true,
@@ -121,7 +118,6 @@ void main() {
       expect(customConfig.serverZone, ServerZone.eu);
       expect(customConfig.serverUrl, 'https://custom.server.url');
       expect(customConfig.minTimeBetweenSessionsMillis, 2000);
-      expect(customConfig.offline, true);
       expect(customConfig.trackingOptions.language, false);
       expect(customConfig.defaultTracking.sessions, false);
       expect(customConfig.enableCoppaControl, true);