Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clarify the meaning of aggregate performance metrics in quera #188

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

peterkomar-aws
Copy link
Contributor

Issue #, if available:

Description of changes:
Updates to the docstrings of the aggregate performance metrics of the QuEra device. Now they explicitly explain that these peformance measures correspond to the 4-microsecond mark in the quantum evolution.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@peterkomar-aws peterkomar-aws requested a review from a team as a code owner December 5, 2024 15:31
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (76fa8c8) to head (870b9ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #188   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         1481      1481           
  Branches        17        17           
=========================================
  Hits          1481      1481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmshaffer rmshaffer merged commit c1f2211 into main Dec 5, 2024
42 checks passed
@rmshaffer rmshaffer deleted the fix-clarify-quera-device-schema branch December 5, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants