Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added org-super-agenda-header-suffix #270

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KamWithK
Copy link

PR for #269

@KamWithK
Copy link
Author

@alphapapa would be great if you can take a look!

@alphapapa
Copy link
Owner

Sorry, it's been a rough week, and I've been very busy with work for the past few months.

@alphapapa
Copy link
Owner

This is fine with me. Would you please add a changelog entry to the readme matching the format of the other entries? Then I will merge it.

@alphapapa alphapapa self-assigned this Nov 16, 2024
@alphapapa alphapapa added this to the 1.4 milestone Nov 16, 2024
@KamWithK
Copy link
Author

This is fine with me. Would you please add a changelog entry to the readme matching the format of the other entries? Then I will merge it.

Will do!

@KamWithK
Copy link
Author

Sorry, it's been a rough week, and I've been very busy with work for the past few months.

Absolutely zero stress, I know exactly what it's like from my own projects
We all do this stuff in our free time so take it easy and enjoy

@KamWithK
Copy link
Author

This is fine with me. Would you please add a changelog entry to the readme matching the format of the other entries? Then I will merge it.

Done @alphapapa

@KamWithK
Copy link
Author

KamWithK commented Nov 29, 2024

Just a quick reminder that it'd be great if you could take another look soon :) @alphapapa

@alphapapa
Copy link
Owner

@KamWithK Thanks for the reminder, but I have had a lot going on lately (death in the family, new job, etc), and I haven't had much time for Emacs projects lately. When I do, there are tens of issues and PRs I could choose to work on with that limited time. If this feature is important to you, since it's practically a two-line patch, I'd suggest that you apply the changed functions in your personal Emacs config until I have time to merge it upstream. For example:

(use-package org-super-agenda
  :config
  (defvar org-super-agenda-header-suffix " ")
  (defun org-super-agenda--make-agenda-header ...))

Or you could install it as a package from your fork with Quelpa or package-vc-install, etc. That way you aren't depending on how soon I have time to do something.

Thanks for your understanding.

@KamWithK
Copy link
Author

KamWithK commented Dec 2, 2024

@KamWithK Thanks for the reminder, but I have had a lot going on lately (death in the family, new job, etc), and I haven't had much time for Emacs projects lately. When I do, there are tens of issues and PRs I could choose to work on with that limited time. If this feature is important to you, since it's practically a two-line patch, I'd suggest that you apply the changed functions in your personal Emacs config until I have time to merge it upstream. For example:

(use-package org-super-agenda
  :config
  (defvar org-super-agenda-header-suffix " ")
  (defun org-super-agenda--make-agenda-header ...))

Or you could install it as a package from your fork with Quelpa or package-vc-install, etc. That way you aren't depending on how soon I have time to do something.

Thanks for your understanding.

I'm sorry to hear that, I hope things take a turn for the better for you!

Just pinged because you'd looked over it already and only requested the contributor docs changed.
I already do use it in my config but it's a bit fragile, so was hoping it'd get merged haha.
Didn't mean to pressure/stress you out at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants