Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-11850 Update CSP > report-to #3788

Merged
merged 1 commit into from
Jan 18, 2024
Merged

PP-11850 Update CSP > report-to #3788

merged 1 commit into from
Jan 18, 2024

Conversation

iqbalgds
Copy link
Contributor

  • Missed out the Reporting-Endpoints header.
  • Required slightly rewriting how we specify the CSP in Helmet.

@iqbalgds iqbalgds force-pushed the pp-11850-update-csp-report-to branch from 4f9f368 to f0b6fd9 Compare January 18, 2024 13:59
@iqbalgds
PP-11850 Update CSP > report-to
70ab331 
- Missed out the `Reporting-Endpoints` header.
- Required slightly rewriting how we specify the CSP in Helmet.
@iqbalgds iqbalgds force-pushed the pp-11850-update-csp-report-to branch from f0b6fd9 to 70ab331 Compare January 18, 2024 14:24
hjvoid
hjvoid approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@hjvoid hjvoid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confident that this change does not require further review and meets the secure coding requirements of GOV.UK Pay

@iqbalgds iqbalgds merged commit 1101348 into master Jan 18, 2024
10 checks passed
@iqbalgds iqbalgds deleted the pp-11850-update-csp-report-to branch January 18, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjvoid hjvoid hjvoid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iqbalgds @hjvoid