Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11578 Support Google Pay for sandbox #3762

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

stephencdaly
Copy link
Contributor

  • Show Google Pay option for sandbox accounts, if the allow_google_pay flag is set to true for the gateway account

  • At this time, do not support an environment variable for disabling Google Pay on sandbox. We suspect we will not have the need to disable it globally, as if it stops working on Sandbox it will not affect paying users.

  • Add pact test for making a request to connector to authorise a sandbox Google Pay payment when connector returns a success response. This commit does not add a Pact test for a declined response - this will come in a later commit as we need a special state for this.

- Show Google Pay option for sandbox accounts, if the
`allow_google_pay` flag is set to true for the gateway account
- At this time, do not support an environment variable for disabling
Google Pay on sandbox. We suspect we will not have the need to
disable it globally, as if it stops working on Sandbox it will not
affect paying users.

- Add pact test for making a request to connector to authorise a
sandbox Google Pay payment when connector returns a success response.
This commit does not add a Pact test for a declined response - this
will come in a later commit as we need a special state for this.
@stephencdaly stephencdaly marked this pull request as ready for review November 10, 2023 09:11
Copy link
Contributor

@james-peacock-gds james-peacock-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephencdaly stephencdaly merged commit 7418a51 into master Nov 10, 2023
5 checks passed
@stephencdaly stephencdaly deleted the PP-11578-support-google-pay-for-sandbox branch November 10, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants