PP-11601 Improve how we handle rejected authorisation for wallets. #3756
Conversation
As part of the review, a Pact test update was requested as per AC.
As part of the review, a Pact test update was requested as per AC. With secrets.baseline update
As part of the review, a Pact test update was requested as per AC. With secrets.baseline update
olatomgds
force-pushed
the
PP-11601-Handle-rejected-authorisation-Tests
branch
from
c8bcd76 to
ceb7f12
Compare
There was a problem hiding this comment.
two of these commits have identical messages and should be squashed, I'd also suggest keeping any commit messages relevant to the changes in the PR.
for ex.
PP-11601 improve rejected authorisation handling for wallets
- updated apple wallet pact test wrt new error handling behaviour in connector
referencing 'the review' is meaningless for anyone looking back on these changes in the future, please can you tidy up the commit history prior to merging
otherwise looks fine 👍🏻 , I see the google pay side of this work has been moved into a separate story
|
- updated apple wallet pact test wrt new error handling behaviour in connector
As part of the review, a Pact test update was requested as per AC.
WHAT
We recently looked at this in PP-11470: We show a technical problems page when Google Pay payments are declined.
However, we are expecting a 400 to always mean the authorisation was rejected - however, it could also mean that the request to connector has an invalid payload which we should handle by showing an error page.
The original change involves the pay-connector service returning an “error_identifier":"AUTHORISATION_REJECTED" in the error response for declined payments for the authorise wallet payment endpoints so we can be sure the 400 means the payment has been declined.
This change involved updating the Pact test to cover this error handling implementation
HOW
Review and run Pact test
connector-client-apple-authentication.pact.test.jsand associated stub.