PP-11638 Move client-side logging for wallet available #3755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were logging that wallet payment methods were shown to the end user fewer times than they were being selected. Move where we log whether the the wallet methods are available to the same place we add the classes to make the buttons visible. What was probably happening was a race condition between the JavaScript that shows the button and the JavaScript that checks whether the button is shown to log the message. Remove the code that just sends some Google Analytics events as we do not use Google Analytics currently, and have not for some time. Additionally, log when we remove the Wallet buttons because our scripts haven't loaded properly.
|
Looks good - some Cypress test's are failing |
Thanks - I think what I tried isn't going to work. Will have to try something else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were logging that wallet payment methods were shown to the end user fewer times than they were being selected.
Move where we log whether the the wallet methods are available to the same place we add the classes to make the buttons visible. What was probably happening was a race condition between the JavaScript that shows the button and the JavaScript that checks whether the button is shown to log the message.
Remove the code that just sends some Google Analytics events as we do not use Google Analytics currently, and have not for some time.
Additionally, log when we remove the Wallet buttons because our scripts haven't loaded properly.