-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for mysql caching_sha2_password
default
#550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one non-blocking request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for getting this documented!
I'm not sure it needs quite such a detailed introduction (perhaps some of the context can be added to the commit message itself, rather than the doc), as most devs will just want to dive in and copy and paste the fixes. But happy to leave it in if it's useful 👍
Great thanks both, will get those amended today |
356258b
to
e8c4042
Compare
e8c4042
to
5dd8a22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 one non-blocking comment if you fancy addressing before merging. Shouldn't need a re-review from me.
In December 2021 we began work to update our database versions. One target of this work was to upgrade from MySQL v5.5 to v8. For example [see whitehall here](#546) MySQL 8.0 contains a plugin "[Caching SHA-2 Pluggable Authentication](https://dev.mysql.com/doc/refman/8.0/en/caching-sha2-pluggable-authentication.html)" that implements SHA-256 hashing for user account passwords. In MySQL 8.0 `caching_sha2_password` was made the default over the previous `mysql_native_password`. `caching_sha2_password` requires a secure connection or an unencrypted connection that supports password exchange using an RSA key pair, which `govuk-docker` is not currently set up to provide.
ad234ae
to
2ebace2
Compare
This stumped me for a couple of days.
Since the mysql 8.0 update I had been unable to
make whitehall
seeing errors when i tried to run:govuk-docker run whitehall-lite bundle exec rails db:prepare
.The stack trace was as follows:
This seems to be related to a change in MySQL password default config in v8.
This documents a solution, (with massive thanks to @ChrisBAshton and @brucebolt)
We may want to find a more sustainable solution as part of the MySQL docker setup.
I have created an issue here for that.