Add additional information to Email model #2024
Conversation
| @@ -23,6 +23,13 @@ def create | |||
| UnsubscribeAllService.call(subscriber, :non_existent_email) if subscriber | |||
| end | |||
|
|
|||
| begin | |||
| Email.where(id: reference).update!(notify_status: status) | |||
There was a problem hiding this comment.
Email.where(id: reference).update!(notify_status: status) -> Email.find(reference).update!(notify_status: status)
There was a problem hiding this comment.
Yeah... I have one very mild reservation about this, which is that find returns an array and I can't call explain on it to check how it's doing the find. But I'm going to assume it does the right thing behind the scenes, so I'll make the change.
There was a problem hiding this comment.
I think find will only return an array if an array is passed to it, passing just a string should just return the email object (if it exists), but yeah you can't find the query information from the return object. However, I'd be very surprised if find didn't use the newly created index (assume that's what you're verifying). Could also check this via Postgres logs.
Here we're just doing it straight off in the callback. This is probably quick enough (I suspect adding the worker infrastructure to queue it might make it slower), but we should confirm that.
KludgeKML
force-pushed
the
add-content-id-to-email
branch
from
50be8af to
e4ef5f2
Compare
Adds content_id and notify_status columns to the Email model, and the support code to populate them - the content_id from the immediate email builder and the notify_status from the callback endpoint. Also adds an index on the existing email id field so that we have a fast lookup during the callback endpoint rather than a field scan.
https://trello.com/c/xdMu72UJ/2245-add-new-information-to-email-alert-api-email-model