-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rails from 7.2.2 to 8.0.0 #999
base: main
Are you sure you want to change the base?
Changes from 2 commits
5a89b6f
837029d
e544d0e
80fce2e
9229aa2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
#!/usr/bin/env ruby | ||
exec "./bin/rails", "server", *ARGV |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
#!/usr/bin/env ruby | ||
require "rubygems" | ||
require "bundler/setup" | ||
|
||
load Gem.bin_path("thruster", "thrust") |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,9 +3,7 @@ | |
Rails.application.configure do | ||
# Settings specified here will take precedence over those in config/application.rb. | ||
|
||
# In the development environment your application's code is reloaded any time | ||
# it changes. This slows down response time but is perfect for development | ||
# since you don't have to restart the web server when you make code changes. | ||
# Make code changes take effect immediately without server restart. | ||
config.enable_reloading = true | ||
|
||
# Do not eager load code on boot. | ||
|
@@ -17,48 +15,40 @@ | |
# Enable server timing. | ||
config.server_timing = true | ||
|
||
# Enable/disable caching. By default caching is disabled. | ||
# Run rails dev:cache to toggle caching. | ||
# Enable/disable Action Controller caching. By default Action Controller caching is disabled. | ||
# Run rails dev:cache to toggle Action Controller caching. | ||
if Rails.root.join("tmp/caching-dev.txt").exist? | ||
config.action_controller.perform_caching = true | ||
config.action_controller.enable_fragment_cache_logging = true | ||
|
||
config.cache_store = :memory_store | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So are these conditional There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep: rails/rails@9c8716a |
||
config.public_file_server.headers = { "Cache-Control" => "public, max-age=#{2.days.to_i}" } | ||
config.public_file_server.headers = { "cache-control" => "public, max-age=#{2.days.to_i}" } | ||
else | ||
config.action_controller.perform_caching = false | ||
|
||
config.cache_store = :null_store | ||
end | ||
|
||
# Change to :null_store to avoid any caching. | ||
config.cache_store = :memory_store | ||
|
||
# Print deprecation notices to the Rails logger. | ||
config.active_support.deprecation = :log | ||
|
||
# Raise exceptions for disallowed deprecations. | ||
config.active_support.disallowed_deprecation = :raise | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this setting now the default in development or something? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think the underlying default changed. It looks like the setting was just removed because DHH thought it wouldn't be useful for new apps: rails/rails@506d728 |
||
|
||
# Tell Active Support which deprecation messages to disallow. | ||
config.active_support.disallowed_deprecation_warnings = [] | ||
|
||
# Raise an error on page load if there are pending migrations. | ||
config.active_record.migration_error = :page_load | ||
|
||
# Highlight code that triggered database queries in logs. | ||
config.active_record.verbose_query_logs = true | ||
|
||
# Append comments with runtime information tags to SQL queries in logs. | ||
config.active_record.query_log_tags_enabled = true | ||
|
||
# Raises error for missing translations. | ||
# config.i18n.raise_on_missing_translations = true | ||
|
||
# Annotate rendered view with file names. | ||
# config.action_view.annotate_rendered_view_with_filenames = true | ||
config.action_view.annotate_rendered_view_with_filenames = true | ||
|
||
# Raise error when a before_action's only/except options reference missing actions. | ||
config.action_controller.raise_on_missing_callback_actions = true | ||
|
||
# Apply autocorrection by RuboCop to files generated by `bin/rails generate`. | ||
# config.generators.apply_rubocop_autocorrect_after_generate! | ||
|
||
config.hosts += [ | ||
"authenticating-proxy.dev.gov.uk", | ||
] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What difference does this change make? |
||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this change really result from running
rails app:update
?