request model validation check

alnck · Feb 13, 2022 · d84d68e · d84d68e
1 parent 3f510a5
commit d84d68e
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 0 deletions.
diff --git a/src/services/blog-api/handler/blogHandler.go b/src/services/blog-api/handler/blogHandler.go
@@ -22,6 +22,11 @@ func CreateStory(context *gin.Context) {
 		badRequest(context, http.StatusBadRequest, "invalid request", errors)
 	}
 
+	if err := story.IsValid(); err != nil {
+		badRequest(context, http.StatusBadRequest, "invalid request", err)
+		return
+	}
+
 	cu := helper.GetCurrentUser(context)
 	newStory := entities.NewStory(story.Title, story.Content, cu.ID)
 
@@ -42,6 +47,11 @@ func UpdateStory(context *gin.Context) {
 		badRequest(context, http.StatusBadRequest, "invalid request", errors)
 	}
 
+	if err := story.IsValid(); err != nil {
+		badRequest(context, http.StatusBadRequest, "invalid request", err)
+		return
+	}
+
 	storyService := services.NewStoryService(context)
 	storyService.UpdateStory(story)
 

diff --git a/src/services/blog-api/handler/loginHandler.go b/src/services/blog-api/handler/loginHandler.go
@@ -23,6 +23,11 @@ func LoginHandler(context *gin.Context) {
 		return
 	}
 
+	if err := loginObj.IsValid(); err != nil {
+		badRequest(context, http.StatusBadRequest, "invalid request", err)
+		return
+	}
+
 	userService := services.NewUserService()
 	genrateJWTToken(context, loginObj, userService)
 

diff --git a/src/services/blog-api/models/loginRequest.go b/src/services/blog-api/models/loginRequest.go
@@ -5,3 +5,19 @@ type LoginRequest struct {
 	Password   string `json:"Password" form:"Password" binding:"required"`
 	RememberMe bool   `json:"RememberMe" form:"RememberMe"`
 }
+
+func (lr LoginRequest) IsValid() (errs []ErrorDetail) {
+	if lr.UserName == "" {
+		errs = append(errs, ErrorDetail{ErrorType: ErrorTypeValidation, ErrorMessage: "The username is required!"})
+	}
+	if len(lr.UserName) < 5 || len(lr.UserName) > 10 {
+		errs = append(errs, ErrorDetail{ErrorType: ErrorTypeValidation, ErrorMessage: "The username field must be between 5-10 chars!"})
+	}
+	if lr.Password == "" {
+		errs = append(errs, ErrorDetail{ErrorType: ErrorTypeValidation, ErrorMessage: "The password is required!"})
+	}
+	if len(lr.Password) < 5 || len(lr.Password) > 10 {
+		errs = append(errs, ErrorDetail{ErrorType: ErrorTypeValidation, ErrorMessage: "The password field must be between 5-10 chars!"})
+	}
+	return errs
+}
diff --git a/src/services/blog-api/models/storyRequest.go b/src/services/blog-api/models/storyRequest.go
@@ -4,3 +4,13 @@ type StoryRequest struct {
 	Title   string `json:"Title"`
 	Content string `json:"Content"`
 }
+
+func (sr StoryRequest) IsValid() (errs []ErrorDetail) {
+	if sr.Title == "" {
+		errs = append(errs, ErrorDetail{ErrorType: ErrorTypeValidation, ErrorMessage: "The title is required!"})
+	}
+	if sr.Content == "" {
+		errs = append(errs, ErrorDetail{ErrorType: ErrorTypeValidation, ErrorMessage: "The content is required!"})
+	}
+	return errs
+}