Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the 1 to the end of email in UserService #663

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Added the 1 to the end of email in UserService #663

merged 1 commit into from
Nov 4, 2024

Conversation

dm9965
Copy link
Contributor

@dm9965 dm9965 commented Oct 28, 2024

  • No discrepancies across browsers. Eg. chrome vs safari
  • Pages pass W3C Validation for HTML (https://validator.w3.org)
  • CSS (https://jigsaw.w3.org/css-validator/)
  • Google sign-in is operational
  • Accessibility functions
  • Pages can scale without distorting page
  • No dead links
  • Navbar is consistent across the site
  • Pages are screen-reader accessible
  • Contrast meets standards for accessibility
  • Pages are keyboard accessible
  • Passes WAVE Evaluation Tool chrome extension

@dm9965 dm9965 linked an issue Oct 28, 2024 that may be closed by this pull request
HOT FIX: UserService Not Saving Groups #662
Closed
@dm9965 dm9965 self-assigned this Oct 28, 2024
@heathermoses heathermoses added the bug Something isn't working label Oct 29, 2024
heathermoses
heathermoses approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@heathermoses heathermoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@dm9965 dm9965 merged commit e24f342 into dev Nov 4, 2024
3 checks passed
@dm9965 dm9965 deleted the 662-hot-fix-userservice-not-saving-groups branch November 4, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heathermoses heathermoses heathermoses approved these changes

@notcruz notcruz Awaiting requested review from notcruz

Assignees

@dm9965 dm9965

Labels
bug Something isn't working
Projects
Accessible Learning Labs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HOT FIX: UserService Not Saving Groups
2 participants
@dm9965 @heathermoses