Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

639 create universal all modal #642

Merged
merged 7 commits into from
Oct 10, 2024
Merged

639 create universal all modal #642

merged 7 commits into from
Oct 10, 2024

Conversation

dm9965
Copy link
Contributor

@dm9965 dm9965 commented Oct 10, 2024

  • No discrepancies across browsers. Eg. chrome vs safari
  • Pages pass W3C Validation for HTML (https://validator.w3.org)
  • CSS (https://jigsaw.w3.org/css-validator/)
  • Google sign-in is operational
  • Accessibility functions
  • Pages can scale without distorting page
  • No dead links
  • Navbar is consistent across the site
  • Pages are screen-reader accessible
  • Contrast meets standards for accessibility
  • Pages are keyboard accessible
  • Passes WAVE Evaluation Tool chrome extension

Create Universal ALL-Branded Modal

Work Completed

Created Dynamic ALL-branded Modal that allows the developer to set the direction of the elements in the modal, as well as input a body containing React Components, strings, etc in the footer section.

How to Test

To test, use the two buttons in the image below as they show both row and column styling, along with a current iteration of the new sign-in modal.

Screenshot 2024-10-10 at 10 17 35 AM

@dm9965 dm9965 linked an issue Oct 10, 2024 that may be closed by this pull request
17 tasks
Copy link
Contributor

@heathermoses heathermoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! We walked through this together

@dm9965 dm9965 merged commit 8fed2a9 into dev Oct 10, 2024
3 checks passed
@dm9965 dm9965 deleted the 639-create-universal-all-modal branch October 10, 2024 17:43
@dm9965 dm9965 restored the 639-create-universal-all-modal branch October 10, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Universal ALL-Branded Modal
3 participants