Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

622 story lab backnext buttons #635

Merged
merged 14 commits into from
Oct 22, 2024

Conversation

mjd3502
Copy link
Contributor

@mjd3502 mjd3502 commented Oct 2, 2024

May need to change sizing of the buttons later, awaiting UI approval.

  • No discrepancies across browsers. Eg. chrome vs safari
  • Pages pass W3C Validation for HTML (https://validator.w3.org)
  • CSS (https://jigsaw.w3.org/css-validator/)
  • Google sign-in is operational
  • Accessibility functions
  • Pages can scale without distorting page
  • No dead links
  • Navbar is consistent across the site
  • Pages are screen-reader accessible
  • Contrast meets standards for accessibility
  • Pages are keyboard accessible
  • Passes WAVE Evaluation Tool chrome extension

@mjd3502 mjd3502 linked an issue Oct 2, 2024 that may be closed by this pull request
18 tasks
@heathermoses heathermoses added this to the UI Refresh milestone Oct 3, 2024
Copy link
Contributor

@heathermoses heathermoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this Michael!

client/src/components/footer/footer.js Outdated Show resolved Hide resolved
client/src/components/footer/footer.js Outdated Show resolved Hide resolved
client/src/components/footer/footer.js Outdated Show resolved Hide resolved
client/src/components/footer/footer.js Outdated Show resolved Hide resolved
client/src/components/footer/footer.js Outdated Show resolved Hide resolved
client/src/components/footer/footer.js Outdated Show resolved Hide resolved
client/src/components/footer/footer.js Outdated Show resolved Hide resolved
@dm9965 dm9965 mentioned this pull request Oct 8, 2024
20 tasks
Copy link
Contributor

@dm9965 dm9965 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small Nit: When you click the button, a small black border appears around the button for a second. If you could remove this by implementing the following tailwind styling in the Back and Next buttons:

focus:tw-border-0

This will remove the little black box that appears around the button!

Copy link
Contributor

@heathermoses heathermoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dm9965 dm9965 changed the base branch from dev to development/ui-refresh October 22, 2024 19:25
Copy link
Contributor

@dm9965 dm9965 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented React Prop types to file and reintroduced accessibility settings in non lab footer. Now ready for merge. LGTM.

@dm9965 dm9965 merged commit 93baa1e into development/ui-refresh Oct 22, 2024
@dm9965 dm9965 deleted the 622-story-lab-backnext-buttons branch October 22, 2024 19:50
@dm9965 dm9965 mentioned this pull request Nov 22, 2024
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Story: Lab Back/Next Buttons
4 participants