-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
622 story lab backnext buttons #635
622 story lab backnext buttons #635
Conversation
Update README to use latest version of Docker
Lab 6 - Replaced Paywalled Readings
… are little odd. Clean up commented code next!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start on this Michael!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small Nit: When you click the button, a small black border appears around the button for a second. If you could remove this by implementing the following tailwind styling in the Back and Next buttons:
focus:tw-border-0
This will remove the little black box that appears around the button!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… into 622-story-lab-backnext-buttons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented React Prop types to file and reintroduced accessibility settings in non lab footer. Now ready for merge. LGTM.
May need to change sizing of the buttons later, awaiting UI approval.