Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): strengthen version check cache prevention #337

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

drichar
Copy link
Collaborator

@drichar drichar commented Jan 12, 2025

Description

This PR enhances the version check system with more robust cache prevention headers. While v0.12.1 (release) added initial cache-busting via query parameters, this change implements a more standards-compliant approach using HTTP cache validation headers.

Details

  • Change fetch cache mode to no-cache to work better with HTTP caching model
  • Add If-None-Match and If-Modified-Since validation headers
  • Maintain existing cache-busting query parameter as additional safeguard
  • Allow proper 304 Not Modified responses for better efficiency

- Change cache mode from `no-store` to `no-cache` to allow revalidation
- Add `If-None-Match` and `If-Modified-Since` headers to force server revalidation
- Simplify `Cache-Control` header to essential directive
Copy link

vercel bot commented Jan 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reti ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2025 4:52am

@drichar drichar merged commit 9d88604 into dev Jan 12, 2025
4 checks passed
@drichar drichar deleted the fix/ui-check-for-updates-cache-headers branch January 12, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants