Remove buffer usage in favor or Uint8Array and Dataview

examples/accounts.ts

@@ -100,7 +100,11 @@ async function main() {
 
   const acctInfo = await client.accountInformation(acct1.addr).do();
 
-  console.log(`Account Info: ${acctInfo} Auth Addr: ${acctInfo['auth-addr']}`);
+  console.log(
+    `Account Info: ${JSON.stringify(acctInfo)} Auth Addr: ${
+      acctInfo['auth-addr']
+    }`
+  );
   // example: ACCOUNT_REKEY
 
   // the transaction is from originalAccount, but signed with newSigner private key

examples/app.ts

@@ -4,7 +4,6 @@
 /* eslint-disable no-console */
 import fs from 'fs';
 import path from 'path';
-import { Buffer } from 'buffer';
 import { getLocalAlgodClient, getLocalAccounts, compileProgram } from './utils';
 import algosdk from '../src';
 
@@ -27,20 +26,16 @@ async function main() {
   // example: APP_SOURCE
 
   // example: APP_COMPILE
-  const approvalCompileResp = await algodClient
-    .compile(Buffer.from(approvalProgram))
-    .do();
+  const approvalCompileResp = await algodClient.compile(approvalProgram).do();
 
-  const compiledApprovalProgram = new Uint8Array(
-    Buffer.from(approvalCompileResp.result, 'base64')
+  const compiledApprovalProgram: Uint8Array = algosdk.base64ToBytes(
+    approvalCompileResp.result
   );
 
-  const clearCompileResp = await algodClient
-    .compile(Buffer.from(clearProgram))
-    .do();
+  const clearCompileResp = await algodClient.compile(clearProgram).do();
 
-  const compiledClearProgram = new Uint8Array(
-    Buffer.from(clearCompileResp.result, 'base64')
+  const compiledClearProgram: Uint8Array = algosdk.base64ToBytes(
+    clearCompileResp.result
   );
   // example: APP_COMPILE
 
@@ -55,8 +50,8 @@ async function main() {
   // example: APP_CREATE
   const appCreateTxn = algosdk.makeApplicationCreateTxnFromObject({
     from: creator.addr,
-    approvalProgram: compiledApprovalProgram,
-    clearProgram: compiledClearProgram,
+    approvalProgram: new Uint8Array(compiledApprovalProgram),
+    clearProgram: new Uint8Array(compiledClearProgram),
     numGlobalByteSlices,
     numGlobalInts,
     numLocalByteSlices,
@@ -138,7 +133,7 @@ async function main() {
     from: caller.addr,
     suggestedParams,
     appIndex: appId,
-    appArgs: [new Uint8Array(Buffer.from(now))],
+    appArgs: [new TextEncoder().encode(now)],
   });
 
   await algodClient
@@ -157,10 +152,10 @@ async function main() {
   console.log(`Raw global state - ${JSON.stringify(globalState)}`);
 
   // decode b64 string key with Buffer
-  const globalKey = Buffer.from(globalState.key, 'base64').toString();
+  const globalKey = algosdk.base64ToString(globalState.key);
   // decode b64 address value with encodeAddress and Buffer
   const globalValue = algosdk.encodeAddress(
-    Buffer.from(globalState.value.bytes, 'base64')
+    algosdk.base64ToBytes(globalState.value.bytes)
   );
 
   console.log(`Decoded global state - ${globalKey}: ${globalValue}`);
@@ -173,7 +168,7 @@ async function main() {
   console.log(`Raw local state - ${JSON.stringify(localState)}`);
 
   // decode b64 string key with Buffer
-  const localKey = Buffer.from(localState.key, 'base64').toString();
+  const localKey = algosdk.base64ToString(localState.key);
   // get uint value directly
   const localValue = localState.value.uint;
 
@@ -209,8 +204,8 @@ async function main() {
     suggestedParams,
     appIndex: appId,
     // updates must define both approval and clear programs, even if unchanged
-    approvalProgram: compiledNewProgram,
-    clearProgram: compiledClearProgram,
+    approvalProgram: new Uint8Array(compiledNewProgram),
+    clearProgram: new Uint8Array(compiledClearProgram),
   });
 
   await algodClient

examples/asa.ts

@@ -46,10 +46,10 @@ async function main() {
   // example: ASSET_INFO
   const assetInfo = await algodClient.getAssetByID(assetIndex).do();
   console.log(`Asset Name: ${assetInfo.params.name}`);
-  console.log(`Asset Params: ${assetInfo.params}`);
+  console.log(`Asset Params: ${JSON.stringify(assetInfo.params)}`);
   // example: ASSET_INFO
 
-  await new Promise((f) => setTimeout(f, 45000)); // sleep to ensure indexer is caught up
+  await new Promise((f) => setTimeout(f, 2000)); // sleep to ensure indexer is caught up
 
   // example: INDEXER_LOOKUP_ASSET
   const indexer = getLocalIndexerClient();

examples/atc.ts

@@ -4,7 +4,6 @@
 /* eslint-disable no-console */
 import fs from 'fs';
 import path from 'path';
-import { Buffer } from 'buffer';
 import algosdk from '../src';
 import { getLocalAlgodClient, getLocalAccounts, compileProgram } from './utils';
 
@@ -99,7 +98,7 @@ async function main() {
 
   // example: ATC_BOX_REF
   const boxATC = new algosdk.AtomicTransactionComposer();
-  const boxKey = new Uint8Array(Buffer.from('key'));
+  const boxKey = new TextEncoder().encode('key');
   boxATC.addMethodCall({
     appID: appIndex,
     method: boxAccessorMethod,

examples/codec.ts

@@ -2,7 +2,6 @@
 /* eslint-disable import/no-unresolved */
 /* eslint-disable no-promise-executor-return */
 /* eslint-disable no-console */
-import { Buffer } from 'buffer';
 import algosdk from '../src';
 import { getLocalAlgodClient, getLocalAccounts } from './utils';
 
@@ -22,7 +21,7 @@ async function main() {
 
   // example: CODEC_BASE64
   const b64Encoded = 'SGksIEknbSBkZWNvZGVkIGZyb20gYmFzZTY0';
-  const b64Decoded = Buffer.from(b64Encoded, 'base64').toString();
+  const b64Decoded = algosdk.base64ToString(b64Encoded);
   console.log(b64Encoded, b64Decoded);
   // example: CODEC_BASE64
 
@@ -43,19 +42,19 @@ async function main() {
   });
 
   const txnBytes = algosdk.encodeUnsignedTransaction(txn);
-  const txnB64 = Buffer.from(txnBytes).toString('base64');
+  const txnB64 = algosdk.bytesToBase64(txnBytes);
   // ...
   const restoredTxn = algosdk.decodeUnsignedTransaction(
-    Buffer.from(txnB64, 'base64')
+    algosdk.base64ToBytes(txnB64)
   );
   console.log(restoredTxn);
   // example: CODEC_TRANSACTION_UNSIGNED
 
   // example: CODEC_TRANSACTION_SIGNED
   const signedTxn = txn.signTxn(sender.privateKey);
-  const signedB64Txn = Buffer.from(signedTxn).toString('base64');
+  const signedB64Txn = algosdk.bytesToBase64(signedTxn);
   const restoredSignedTxn = algosdk.decodeSignedTransaction(
-    Buffer.from(signedB64Txn, 'base64')
+    algosdk.base64ToBytes(signedB64Txn)
   );
   console.log(restoredSignedTxn);
   // example: CODEC_TRANSACTION_SIGNED
@@ -65,7 +64,7 @@ async function main() {
 
   const stringTupleData = ['hello', 'world'];
   const encodedTuple = stringTupleCodec.encode(stringTupleData);
-  console.log(Buffer.from(encodedTuple).toString('hex'));
+  console.log(algosdk.bytesToHex(encodedTuple));
 
   const decodedTuple = stringTupleCodec.decode(encodedTuple);
   console.log(decodedTuple); // ['hello', 'world']
@@ -74,7 +73,7 @@ async function main() {
 
   const uintArrayData = [1, 2, 3, 4, 5];
   const encodedArray = uintArrayCodec.encode(uintArrayData);
-  console.log(Buffer.from(encodedArray).toString('hex'));
+  console.log(algosdk.bytesToHex(encodedArray));
 
   const decodeArray = uintArrayCodec.decode(encodedArray);
   console.log(decodeArray); // [1, 2, 3, 4, 5]

examples/indexer.ts

@@ -2,7 +2,6 @@
 /* eslint-disable import/no-unresolved */
 /* eslint-disable no-promise-executor-return */
 /* eslint-disable no-console */
-import { Buffer } from 'buffer';
 import {
   getLocalIndexerClient,
   getLocalAccounts,
@@ -68,7 +67,7 @@ async function main() {
     from: sender.addr,
     to: sender.addr,
     amount: 1e6,
-    note: new Uint8Array(Buffer.from('Hello World!')),
+    note: new TextEncoder().encode('Hello World!'),
     suggestedParams,
   });
 
@@ -80,7 +79,7 @@ async function main() {
   // example: INDEXER_PREFIX_SEARCH
   const txnsWithNotePrefix = await indexerClient
     .searchForTransactions()
-    .notePrefix(Buffer.from('Hello'))
+    .notePrefix(new TextEncoder().encode('Hello'))
     .do();
   console.log(
     `Transactions with note prefix "Hello" ${JSON.stringify(

examples/lsig.ts

@@ -2,7 +2,6 @@
 /* eslint-disable import/no-unresolved */
 /* eslint-disable no-promise-executor-return */
 /* eslint-disable no-console */
-import { Buffer } from 'buffer';
 import algosdk from '../src';
 import { getLocalAlgodClient, getLocalAccounts } from './utils';
 
@@ -14,7 +13,9 @@ async function main() {
 
   // example: LSIG_COMPILE
   const smartSigSource = '#pragma version 8\nint 1\nreturn'; // approve everything
-  const result = await client.compile(Buffer.from(smartSigSource)).do();
+  const result = await client
+    .compile(new TextEncoder().encode(smartSigSource))
+    .do();
 
   // Hash is equivalent to the contract address
   console.log('Hash: ', result.hash);
@@ -23,17 +24,12 @@ async function main() {
   // example: LSIG_COMPILE
 
   // example: LSIG_INIT
-  let smartSig = new algosdk.LogicSig(
-    new Uint8Array(Buffer.from(b64program, 'base64'))
-  );
+  let smartSig = new algosdk.LogicSig(algosdk.base64ToBytes(b64program));
   // example: LSIG_INIT
 
   // example: LSIG_PASS_ARGS
-  const args = [Buffer.from('This is an argument!')];
-  smartSig = new algosdk.LogicSig(
-    new Uint8Array(Buffer.from(b64program, 'base64')),
-    args
-  );
+  const args = [new TextEncoder().encode('This is an argument!')];
+  smartSig = new algosdk.LogicSig(algosdk.base64ToBytes(b64program), args);
   // example: LSIG_PASS_ARGS
 
   const fundSmartSigTxn = algosdk.makePaymentTxnWithSuggestedParamsFromObject({

examples/overview.ts

@@ -1,4 +1,3 @@
-import { Buffer } from 'buffer';
 import algosdk from '../src';
 import { getLocalAccounts, getLocalAlgodClient } from './utils';
 
@@ -27,7 +26,7 @@ async function main() {
     suggestedParams,
     to: acct2.addr,
     amount: 10000,
-    note: new Uint8Array(Buffer.from('hello world')),
+    note: new TextEncoder().encode('hello world'),
   });
   // example: TRANSACTION_PAYMENT_CREATE
 
@@ -39,8 +38,10 @@ async function main() {
   const { txId } = await algodClient.sendRawTransaction(signedTxn).do();
   const result = await algosdk.waitForConfirmation(algodClient, txId, 4);
   console.log(result);
-  console.log(`Transaction Information: ${result.txn}`);
-  console.log(`Decoded Note: ${Buffer.from(result.txn.txn.note).toString()}`);
+  console.log(`Transaction Information: ${JSON.stringify(result.txn)}`);
+  console.log(
+    `Decoded Note: ${new TextDecoder('utf-8').decode(result.txn.txn.note)}`
+  );
   // example: TRANSACTION_PAYMENT_SUBMIT
 
   // example: ALGOD_FETCH_ACCOUNT_INFO

examples/utils.ts

@@ -1,16 +1,15 @@
 import fs from 'fs';
 import path from 'path';
-import { Buffer } from 'buffer';
 import algosdk from '../src';
 
 export async function compileProgram(
   client: algosdk.Algodv2,
   programSource: string
 ) {
-  const compileResponse = await client.compile(Buffer.from(programSource)).do();
-  const compiledBytes = new Uint8Array(
-    Buffer.from(compileResponse.result, 'base64')
-  );
+  const compileResponse = await client
+    .compile(new TextEncoder().encode(programSource))
+    .do();
+  const compiledBytes = algosdk.base64ToBytes(compileResponse.result);
   return compiledBytes;
 }
 
@@ -70,7 +69,7 @@ export async function getLocalAccounts(): Promise<SandboxAccount[]> {
 
   const addresses = await kmdClient.listKeys(handle);
   // eslint-disable-next-line camelcase
-  const acctPromises: Promise<{ private_key: Buffer }>[] = [];
+  const acctPromises: Promise<{ private_key: Uint8Array }>[] = [];
 
   // eslint-disable-next-line no-restricted-syntax
   for (const addr of addresses.addresses) {

src/abi/abi_type.ts

@@ -13,7 +13,6 @@
     // | string
     // | (T1, ..., Tn)
 */
-import { Buffer } from 'buffer';
 import { encodeAddress, decodeAddress } from '../encoding/address';
 import { bigIntToBytes, bytesToBigInt } from '../encoding/bigint';
 import { concatArrays } from '../utils/utils';
@@ -380,7 +379,12 @@ export class ABIStringType extends ABIType {
     if (typeof value !== 'string' && !(value instanceof Uint8Array)) {
       throw new Error(`Cannot encode value as string: ${value}`);
     }
-    const encodedBytes = Buffer.from(value);
+    let encodedBytes: Uint8Array;
+    if (typeof value === 'string') {
+      encodedBytes = new TextEncoder().encode(value);
+    } else {
+      encodedBytes = value;
+    }
     const encodedLength = bigIntToBytes(
       encodedBytes.length,
       LENGTH_ENCODE_BYTE_SIZE
@@ -399,8 +403,12 @@ export class ABIStringType extends ABIType {
         `byte string is too short to be decoded. Actual length is ${byteString.length}, but expected at least ${LENGTH_ENCODE_BYTE_SIZE}`
       );
     }
-    const buf = Buffer.from(byteString);
-    const byteLength = buf.readUIntBE(0, LENGTH_ENCODE_BYTE_SIZE);
+    const view = new DataView(
+      byteString.buffer,
+      byteString.byteOffset,
+      LENGTH_ENCODE_BYTE_SIZE
+    );
+    const byteLength = view.getUint16(0);
     const byteValue = byteString.slice(
       LENGTH_ENCODE_BYTE_SIZE,
       byteString.length
@@ -410,7 +418,7 @@ export class ABIStringType extends ABIType {
         `string length bytes do not match the actual length of string. Expected ${byteLength}, got ${byteValue.length}`
       );
     }
-    return Buffer.from(byteValue).toString('utf-8');
+    return new TextDecoder('utf-8').decode(byteValue);
   }
 }
 
@@ -517,8 +525,8 @@ export class ABIArrayDynamicType extends ABIType {
   }
 
   decode(byteString: Uint8Array): ABIValue[] {
-    const buf = Buffer.from(byteString);
-    const byteLength = buf.readUIntBE(0, LENGTH_ENCODE_BYTE_SIZE);
+    const view = new DataView(byteString.buffer, 0, LENGTH_ENCODE_BYTE_SIZE);
+    const byteLength = view.getUint16(0);
     const convertedTuple = this.toABITupleType(byteLength);
     return convertedTuple.decode(
       byteString.slice(LENGTH_ENCODE_BYTE_SIZE, byteString.length)
@@ -660,7 +668,7 @@ export class ABITupleType extends ABIType {
     const valuePartition: Uint8Array[] = [];
     let i = 0;
     let iterIndex = 0;
-    const buf = Buffer.from(byteString);
+    const view = new DataView(byteString.buffer);
 
     while (i < tupleTypes.length) {
       const tupleType = tupleTypes[i];
@@ -671,7 +679,9 @@ export class ABITupleType extends ABIType {
         ) {
           throw new Error('dynamic type in tuple is too short to be decoded');
         }
-        const dynamicIndex = buf.readUIntBE(iterIndex, LENGTH_ENCODE_BYTE_SIZE);
+        // Since LENGTH_ENCODE_BYTE_SIZE is 2 and indices are at most 2 bytes,
+        // we can use getUint16 using the iterIndex offset.
+        const dynamicIndex = view.getUint16(iterIndex);
         if (dynamicSegments.length > 0) {
           dynamicSegments[dynamicSegments.length - 1].right = dynamicIndex;
           // Check that right side of segment is greater than the left side