Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle deleting virtual replicas #168

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix: handle deleting virtual replicas #168

merged 2 commits into from
Jul 22, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Jul 1, 2024 •
edited
Loading

Virtual replica indices have normal index names, e.g. replicaName, but are stored in the index settings as virtual(replicaName). This PR handles deleting virtual replicas with the algolia index delete command.

Fixes #166

@kai687 kai687 marked this pull request as ready for review July 1, 2024 09:33
clemfromspace
clemfromspace approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@clemfromspace clemfromspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@clemfromspace clemfromspace merged commit e922d0d into algolia:main Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemfromspace clemfromspace clemfromspace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleting virtual replica panics
2 participants
@kai687 @clemfromspace