fix: API polling flood issue due to msec sleep time mishandling (#472)

* fix API polling flood issue due to msec sleep time mishandling * for Semantic Pull Request check * fix: API polling flood issue due to msec sleep time mishandling
algolia · Apr 15, 2022 · 90d8ea5 · 90d8ea5
1 parent 052e961
commit 90d8ea5
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/lib/algolia/responses/add_api_key_response.rb b/lib/algolia/responses/add_api_key_response.rb
@@ -28,7 +28,7 @@ def wait(opts = {})
           end
           retries_count    += 1
           time_before_retry = retries_count * Defaults::WAIT_TASK_DEFAULT_TIME_BEFORE_RETRY
-          sleep(time_before_retry / 1000)
+          sleep(time_before_retry.to_f / 1000)
         end
       end
 

diff --git a/lib/algolia/responses/delete_api_key_response.rb b/lib/algolia/responses/delete_api_key_response.rb
@@ -29,7 +29,7 @@ def wait(opts = {})
           unless @done
             retries_count    += 1
             time_before_retry = retries_count * Defaults::WAIT_TASK_DEFAULT_TIME_BEFORE_RETRY
-            sleep(time_before_retry / 1000)
+            sleep(time_before_retry.to_f / 1000)
           end
         end
       end

diff --git a/lib/algolia/responses/restore_api_key_response.rb b/lib/algolia/responses/restore_api_key_response.rb
@@ -26,7 +26,7 @@ def wait(opts = {})
           end
           retries_count    += 1
           time_before_retry = retries_count * Defaults::WAIT_TASK_DEFAULT_TIME_BEFORE_RETRY
-          sleep(time_before_retry / 1000)
+          sleep(time_before_retry.to_f / 1000)
         end
       end
 

diff --git a/lib/algolia/responses/update_api_key_response.rb b/lib/algolia/responses/update_api_key_response.rb
@@ -29,7 +29,7 @@ def wait(opts = {})
           raise e unless e.code == 404
           retries_count    += 1
           time_before_retry = retries_count * Defaults::WAIT_TASK_DEFAULT_TIME_BEFORE_RETRY
-          sleep(time_before_retry / 1000)
+          sleep(time_before_retry.to_f / 1000)
         end
       end
 

diff --git a/lib/algolia/search_index.rb b/lib/algolia/search_index.rb
@@ -36,7 +36,7 @@ def wait_task(task_id, time_before_retry = Defaults::WAIT_TASK_DEFAULT_TIME_BEFO
           if status == 'published'
             return
           end
-          sleep(time_before_retry / 1000)
+          sleep(time_before_retry.to_f / 1000)
         end
       end
-Original file line number
+Diff line change
@@ Expand Up @@
               if status == 'published'
                 return
               end
-              sleep(time_before_retry / 1000)
+              sleep(time_before_retry.to_f / 1000)
             end
           end
@@ Expand Down @@