forked from doomemacs/doomemacs
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow setting evil states for leader keys #2
Open
akhil3417
wants to merge
26
commits into
akhil3417:master
Choose a base branch
from
TheJJ:leader-key-states
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+293
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhil3417
force-pushed
the
master
branch
2 times, most recently
from
July 22, 2023 07:36
5abde7d
to
f87f838
Compare
akhil3417
force-pushed
the
master
branch
2 times, most recently
from
July 29, 2023 17:23
6e9a485
to
6482ea9
Compare
TheJJ
force-pushed
the
leader-key-states
branch
from
August 2, 2023 13:40
9245654
to
8c5342b
Compare
TheJJ
force-pushed
the
leader-key-states
branch
from
August 14, 2023 18:16
8c5342b
to
900df31
Compare
TheJJ
force-pushed
the
leader-key-states
branch
from
August 23, 2023 13:58
900df31
to
bd48c6f
Compare
TheJJ
force-pushed
the
leader-key-states
branch
from
September 29, 2023 15:21
bd48c6f
to
48e489a
Compare
TheJJ
force-pushed
the
leader-key-states
branch
from
October 27, 2023 13:02
48e489a
to
dbcdae4
Compare
TheJJ
force-pushed
the
leader-key-states
branch
from
November 24, 2023 11:34
dbcdae4
to
cb69a54
Compare
TheJJ
force-pushed
the
leader-key-states
branch
2 times, most recently
from
February 7, 2024 10:22
11dc0e4
to
9bc6d87
Compare
TheJJ
force-pushed
the
leader-key-states
branch
from
February 14, 2024 16:13
9bc6d87
to
3060e52
Compare
* feat(vertico): completion highlights a la ivy Adds completion highlighting that works similarly to ivy/counsel's one (which is enabled by default). It'll highlight enabled major/minor modes and directories in a different face. On by default. Ref: https://github.com/minad/vertico/wiki#candidate-display-transformations-custom-candidate-highlighting * fix(vertico): major mode not being highlighted The major mode was not being highlighted correctly; it should work now that the buffer is set correctly in `+vertico-highlight-enabled-mode`. * fix(vertico): make font lock prioritize match over type The mode and directory highlights were [overriding the match font-lock](doomemacs#7706 (comment)). This should resolve that by prioritizing the match font lock using `'append` on `add-face-text-property` instead of `propertize`.
Minor mode highlights did not disable as long as the mode was enabled. Amend: doomemacs#7706
allow +java-current-package and +java-current-class functions to operate on java-ts-mode (the java tree-sitter mode) not just java-mode.
Nim 2.x+ comes with its own formatter (nimpretty). Close: doomemacs#7578 Co-authored-by: pietrangelo <[email protected]>
If the user uses the doom-load-packages-incrementally function directly, and has set doom-incremental-first-idle-timer set to nil, it will throw a type error. Close: doomemacs#7710
This makes load-order more predictable for users wanting to modify the side-effects of citar-org-roam-mode or citar-embark-mode. I.e. (after! citar-org-roam ...) (after! citar-embark ...) Instead of: (after! (citar org-roam) ...) (after! (citar embark) ...) Ref: doomemacs#7712 Co-authored-by: hpfr <[email protected]>
These two features are relatively expensive and shouldn't be enabled as a global default.
I will slowly phase out projectile in favor of project.el, starting with projectile-find-other-file, which -- as of Emacs 29 -- has a native alternative: `find-sibling-file`. Ref: doomemacs/community#1
- Add another measure for preventing changes to tab-width in org-mode. The hook introduced in 2757a97 runs too early and could be overwritten by editorconfig. - Fix the hook in 2757a97 to run much later, ensuring (as a last resort) no other packages can overwrite tab-width either. Amend: 2757a97 Ref: doomemacs#7670
editorconfig-call-editorconfig-exec was renamed+redesigned upstream. The advice can no longer be trivially repurposed, so I'm removing it. Ref: editorconfig/editorconfig-emacs@f8f1a899dfc2
lsp-treemacs changes the default Treemacs theme, so treemacs-nerd-icons needs to be loaded after it, if it's installed/enabled. Fix: doomemacs#7519 Fix: doomemacs/themes#801 Ref: emacs-lsp/lsp-treemacs#89
Tools like these will be moved to a benchmark module later (or perhaps to `:lang emacs-lisp`). For the time being, it only takes up extra space that few users use.
Some site files will forcibly undo `inhibit-message` or set `force-load-messages`. This ensures site lisp files don't make unnecessary noise at startup.
set-repl-handler! handlers have to return a buffer. Close: doomemacs#7450 Co-authored-by: Zetagon <[email protected]>
mu4e-quit now takes an optional argument, BURY, which is a boolean that determines whether to bury the buffer or kill it. This commit updates the advice to reflect this change.
This allows adjusting the evil-states a leader key is active for.
TheJJ
force-pushed
the
leader-key-states
branch
from
March 11, 2024 10:05
3060e52
to
f669661
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows adjusting the evil-states a leader key is active for.