Skip to content

Commit

Permalink
feat: Add capability to disable minio deployment
Browse files Browse the repository at this point in the history
  • Loading branch information
aperigault authored Jul 1, 2024
1 parent d8d9387 commit 6358f24
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/airbyte/templates/minio.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if (eq (lower (default "" .Values.global.storage.type)) "minio")}}
{{- if .Values.minio.enabled }}
apiVersion: apps/v1 # for k8s versions before 1.9.0 use apps/v1beta2 and before 1.8.0 use extensions/v1beta1
kind: StatefulSet
metadata:
Expand Down
26 changes: 22 additions & 4 deletions charts/airbyte/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,16 +75,32 @@ global:
# -- The database user
user: ""
# -- The key within `secretName` where the user is stored
#userSecretKey: "" # e.g. "database-user"
# userSecretKey: "" # e.g. "database-user"

# -- The database password
password: ""
# -- The key within `secretName` where the password is stored
#passwordSecretKey: "" # e.g."database-password"
# passwordSecretKey: "" # e.g."database-password"

storage:
type: minio # default storage used
# TODO: Add full configuration here
type: minio # s3 | gcs | minio - default | (local)
# storageSecretName: airbyte-config-secrets
# bucket:
# activityPayload: airbyte-storage
# log: airbyte-storage
# state: airbyte-storage
# workloadOutput: airbyte-storage
# s3:
# authenticationType: credentials # credentials | instanceProfile
# accessKeyIdSecretKey: aws-secret-manager-access-key-id
# secretAccessKeySecretKey: aws-secret-manager-secret-access-key
# gcs:
# project: <gcp-project>
# credentialsPath: <gcs-credentials> # this is actually be path to file in mount https://docs.airbyte.com/deploying-airbyte/on-kubernetes-via-helm#external-logs-with-gcs
# minio: # only include this if you are using an external minio deployment, otherwise, you can exclude this section entirely as long as you have the type set to minio
# accessKeyIdSecretKey: minio-secret-manager-access-key-id # set to `minio` in your secrets if using local minio instance
# secretAccessKeySecretKey: minio-secret-manager-secret-access-key # set to `minio123` in your secrets if using local minio instance
# endpoint: <minio-endpoint> # set to http://airbyte-minio-svc:9000 if using local minio instance

metrics:
# -- The metric client to configure globally. Supports "otel"
Expand Down Expand Up @@ -1412,6 +1428,8 @@ externalDatabase:
## @section Logs parameters

minio:
# -- Switch to enable or disable the minio helm chart
enabled: true
image:
# -- Minio image used by Minio helm chart
repository: minio/minio
Expand Down

0 comments on commit 6358f24

Please sign in to comment.