Ensure makeSymbol does not change currentPage
#353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,8 +44,10 @@ const getExistingSymbols = (document: any) => { | |||
|
|
|||
| let symbolsPage = getSymbolsPage(document); | |||
There was a problem hiding this comment.
IIRC, there is a document.getOrCreateSymbolPage() method used somewhere else already. We probably want to use that
There was a problem hiding this comment.
I did see it used, but wasn't sure if its implementation was exactly the same as what was happening here.
I kicked the can down the road, because I wasn't entirely sure how long we would be keeping this current Symbols API.
The next thing up on my list is investigating how to control manually rendering SymbolMasters rather then relying on inject.
mathieudutour
approved these changes
Jun 9, 2018
|
@jaridmargolin Could you release a new version that includes this patch? |
|
I actually do not have publish rights... but @mathieudutour does :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick patch to fix #351
Hopefully for a v3 release we can get around all of this hoopla by providing a more natural interface as explained in #316 (comment)