Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.12 #619

Merged
merged 14 commits into from
Jan 13, 2023
Merged

Release 0.12 #619

merged 14 commits into from
Jan 13, 2023

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Jan 2, 2023

Fixes #536.

@Dreamsorcerer
Copy link
Member Author

@webknjaz Doesn't appear to be any deploy keys here. Can you set that up?

@webknjaz
Copy link
Member

webknjaz commented Jan 2, 2023

@Dreamsorcerer yes, there are no secrets with the PyPI API keys in the repo. I've checked and realized that I don't have access to the PyPI project from my personal account or the bot service account. Only @asvetlov and blck seem to be listed there. Maybe, @argaen knows something?

@webknjaz
Copy link
Member

webknjaz commented Jan 2, 2023

FWIW, I also don't have access to RTD. Only @argaen does.

@argaen
Copy link
Member

argaen commented Jan 6, 2023

👋 I still have access to pypi and rtd, I could give access. @webknjaz @Dreamsorcerer should I give access to both of you?

About the keys.. if I have them they are in a laptop I dont have access right now so it's going to take some more time but my suggestion would maybe once you have access to pypi to create a new pair and store them properly

@webknjaz
Copy link
Member

webknjaz commented Jan 6, 2023

@argaen yes, I think you could add me at least, as an Owner on PyPI and RTD. Maybe, both of us to fight the bus factor. Though, strictly speaking, it would be enough to give aio-libs-bot the Maintain privilege on PyPI and this would let me create a scoped token through that account. Thanks!

@Dreamsorcerer
Copy link
Member Author

I don't have access to any other PyPI projects, so @webknjaz is probably fine. Not sure I've even registered an account on PyPI.

@argaen
Copy link
Member

argaen commented Jan 8, 2023

@webknjaz I've sent invitations for both RTD and pypi

@webknjaz
Copy link
Member

webknjaz commented Jan 8, 2023

@argaen thanks, I was able to add the bot there too.

@webknjaz
Copy link
Member

webknjaz commented Jan 8, 2023

@Dreamsorcerer env secret provisioned. Also added a CNAME entry for RTD.

P.S. Looks like a few readme badges need updating.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #619 (cd17585) into master (8267459) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
- Coverage   99.67%   99.67%   -0.01%     
==========================================
  Files          36       35       -1     
  Lines        3713     3712       -1     
==========================================
- Hits         3701     3700       -1     
  Misses         12       12              
Flag Coverage Δ
unit 99.67% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiocache/__init__.py 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c2708...cd17585. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
@Dreamsorcerer Dreamsorcerer merged commit 3f6f3ae into master Jan 13, 2023
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-3 branch January 13, 2023 19:51
@Dreamsorcerer
Copy link
Member Author

@webknjaz Not sure if there's something else needed in the pipeline, but doesn't look like RTD got deployed (atleast the title still says 0.11.1).

@webknjaz
Copy link
Member

@Dreamsorcerer the last passed build was 7h 40min ago, the following ones all fail. See https://readthedocs.org/projects/aiocache/builds/.

@webknjaz
Copy link
Member

I've just enabled the PR builds feature so it'll get more visibility in the future. Plus, if you add the readme badge, it'll also show up red there.

@Dreamsorcerer
Copy link
Member Author

Right, thanks. Didn't realise it was building on each commit. That's easy enough to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New release?
3 participants