-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.12 #619
Release 0.12 #619
Conversation
@webknjaz Doesn't appear to be any deploy keys here. Can you set that up? |
@Dreamsorcerer yes, there are no secrets with the PyPI API keys in the repo. I've checked and realized that I don't have access to the PyPI project from my personal account or the bot service account. Only @asvetlov and |
FWIW, I also don't have access to RTD. Only @argaen does. |
👋 I still have access to pypi and rtd, I could give access. @webknjaz @Dreamsorcerer should I give access to both of you? About the keys.. if I have them they are in a laptop I dont have access right now so it's going to take some more time but my suggestion would maybe once you have access to pypi to create a new pair and store them properly |
@argaen yes, I think you could add me at least, as an Owner on PyPI and RTD. Maybe, both of us to fight the bus factor. Though, strictly speaking, it would be enough to give |
I don't have access to any other PyPI projects, so @webknjaz is probably fine. Not sure I've even registered an account on PyPI. |
@webknjaz I've sent invitations for both RTD and pypi |
@argaen thanks, I was able to add the bot there too. |
@Dreamsorcerer env secret provisioned. Also added a CNAME entry for RTD. P.S. Looks like a few readme badges need updating. |
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
==========================================
- Coverage 99.67% 99.67% -0.01%
==========================================
Files 36 35 -1
Lines 3713 3712 -1
==========================================
- Hits 3701 3700 -1
Misses 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@webknjaz Not sure if there's something else needed in the pipeline, but doesn't look like RTD got deployed (atleast the title still says 0.11.1). |
@Dreamsorcerer the last passed build was 7h 40min ago, the following ones all fail. See https://readthedocs.org/projects/aiocache/builds/. |
I've just enabled the PR builds feature so it'll get more visibility in the future. Plus, if you add the readme badge, it'll also show up red there. |
Right, thanks. Didn't realise it was building on each commit. That's easy enough to fix. |
Fixes #536.