OpenAI o1 support #347
Merged
OpenAI o1 support #347
+278
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hk669
requested review from
sonichi,
qingyun-wu,
davorrunje,
marklysze and
BabyCNM
davorrunje
approved these changes
Jan 15, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
the o1 preview and o1 series models doesnt support the same API parameters (Limitations) as the other openai models, so added a helper function in the OpenAIClient that tackles this issue and can be run in the agentic workflow.
tested with the two agent run (with o1-preview) with a question from simple-bench, and it runs perfectly on my side.
Related issue number
Checks