Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cohere model integrations #338

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Anirudh31415926535
Copy link
Collaborator

Why are these changes needed?

This PR aims to fix the cohere integration to the ag2 repo. This PR essentially contains the changes here and here

Checks

@marklysze marklysze self-requested a review January 3, 2025 17:59
@sonichi sonichi requested review from yiranwu0 and Hk669 January 6, 2025 21:17
@marklysze
Copy link
Collaborator

Hey @Anirudh31415926535, while looking into adding structured output support I saw that the V2 API seemed easier to work with, more aligned with other APIs. I've started work on it in #369. Do you think V2 is better to move forward with?

@Anirudh31415926535
Copy link
Collaborator Author

Hey @Anirudh31415926535, while looking into adding structured output support I saw that the V2 API seemed easier to work with, more aligned with other APIs. I've started work on it in #369. Do you think V2 is better to move forward with?

Hey @marklysze Yes absolutely! Migrating to the cohere integration to V2 was something that we were thinking about as well haha! Would def appreciate the help here! I can help to review the PR if you're willing to contribute!
But I am not sure where the V2 api integration comes into the PR you'd linked though #369 Is it still in progress? Or am I missing something there haha...

@marklysze
Copy link
Collaborator

marklysze commented Jan 7, 2025

Hey @Anirudh31415926535, while looking into adding structured output support I saw that the V2 API seemed easier to work with, more aligned with other APIs. I've started work on it in #369. Do you think V2 is better to move forward with?

Hey @marklysze Yes absolutely! Migrating to the cohere integration to V2 was something that we were thinking about as well haha! Would def appreciate the help here! I can help to review the PR if you're willing to contribute! But I am not sure where the V2 api integration comes into the PR you'd linked though #369 Is it still in progress? Or am I missing something there haha...

:), my bad, wrong PR! it's #370, sorry!

Yes, if we can work on that one that would be better, V2 is so much easier to work with!

Please have a look at the PR and if you're happy to continue there feel free to close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants