Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support missing dummy row in asc files #918

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

dkrako
Copy link
Contributor

@dkrako dkrako commented Jan 7, 2025

Description

Fixes #917

Implemented changes

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • add test file eyelink_monocular_no_dummy_example.asc
  • add test case to functional/gaze_file_processing_test.py
  • add test case to unit/gaze/io/asc_test.py

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@dkrako dkrako linked an issue Jan 7, 2025 that may be closed by this pull request
@dkrako dkrako changed the title add test file and use it in functional test feat: support missing dummy row in asc files Jan 7, 2025
@dkrako dkrako added the enhancement New feature or request label Jan 7, 2025
@dkrako dkrako changed the title feat: support missing dummy row in asc files fix: support missing dummy row in asc files Jan 7, 2025
@dkrako dkrako added bug Something isn't working and removed enhancement New feature or request labels Jan 7, 2025
@github-actions github-actions bot added the enhancement New feature or request label Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c0c11cd) to head (20da09b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #918   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           74        74           
  Lines         3422      3422           
  Branches       613       613           
=========================================
  Hits          3422      3422           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the fix label Jan 7, 2025
@dkrako dkrako removed the enhancement New feature or request label Jan 7, 2025
@dkrako dkrako marked this pull request as draft January 8, 2025 16:15
@dkrako dkrako added the urgent resolve as soon as possible label Jan 8, 2025
@dkrako
Copy link
Contributor Author

dkrako commented Jan 8, 2025

finally I managed to incorporate the example file into the tests.

ready for review @SiQube @prassepaul @senisioi

@dkrako dkrako marked this pull request as ready for review January 8, 2025 17:40
@dkrako dkrako enabled auto-merge (squash) January 8, 2025 17:42
@dkrako dkrako disabled auto-merge January 8, 2025 17:42
@dkrako dkrako enabled auto-merge (squash) January 8, 2025 17:43
@SiQube
Copy link
Member

SiQube commented Jan 9, 2025

I'm not too familiar with this branch of pymovements -- maybe @saeub could review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix urgent resolve as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support missing dummy row in asc files
2 participants