added filtering of 3d and 2d cameras to allow for 3d and 2d cameras to operate simultaneously #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o operate simultaneously
Azorlogh
reviewed
Feb 1, 2024
| Option<&RenderLayers>, | ||
| ), | ||
| With<Camera3d>, | ||
| >, |
There was a problem hiding this comment.
I think this will prevent 2d cameras from picking 2d meshes
|
The raycasting backend should be reporting the camera.order, which the picking plugin uses to sort hits. Do you have a minimal repro of the "unpredictable picking" bug with 2d/3d cams? |
aevyrie
force-pushed
the
2d-and-3d-camera
branch
from
d6e4794 to
5cb783a
Compare
aevyrie
force-pushed
the
2d-and-3d-camera
branch
from
5cb783a to
462ccc9
Compare
|
It appears this is already fixed on |
|
Thank you. Sorry for the radio silence. I was dealing with a sick baby. I appreciate this library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering with 2D and 3D cameras, the results would be very unpredictable. Adding the filter fixed the issue.