Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying feature key by env var #63

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Allow specifying feature key by env var #63

merged 3 commits into from
Nov 5, 2024

Conversation

arrowplum
Copy link
Contributor

Allow specifying the feature key via environment variable when you run docker compose.

For example to use the one I have for aerospike already in /etc/aerospike/features.conf

FEATURE_KEY=/etc/aerospike/features.conf docker compose up

If there is no FEATURE_KEY set it works as before (looking to the container-volumes)

@arrowplum arrowplum requested a review from hev October 26, 2024 00:23
@arrowplum arrowplum mentioned this pull request Oct 28, 2024
Merged
hev
hev approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works and doesn't require changing the quick start - but we probably should update quick start independently.

@arrowplum arrowplum merged commit 8a70df1 into main Nov 5, 2024
1 check passed
@arrowplum arrowplum deleted the VEC-383-feature-key-location branch November 5, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hev hev hev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arrowplum @hev