Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TOOLS-2971 fix in existing failing test cases #56

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

a-spiker
Copy link
Contributor

@a-spiker a-spiker commented Sep 11, 2024

  • Fixing the existing test cases to ensure any further changes in the repo are properly tested.
  • Removing the suppress check on the go test command

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.27%. Comparing base (a8c2fff) to head (5dfc174).

Files with missing lines Patch % Lines
info/as_parser.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   36.34%   36.27%   -0.08%     
==========================================
  Files          23       23              
  Lines        5610     5610              
==========================================
- Hits         2039     2035       -4     
- Misses       3435     3436       +1     
- Partials      136      139       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-spiker a-spiker changed the title fix: Fix existing test cases fix: changes in existing test cases for current test cases Sep 11, 2024
@a-spiker a-spiker changed the title fix: changes in existing test cases for current test cases fix: changes in existing test cases Sep 11, 2024
@a-spiker a-spiker changed the title fix: changes in existing test cases fix: TOOLS-2971 fix in existing failing test cases Sep 11, 2024
@a-spiker a-spiker marked this pull request as ready for review September 11, 2024 17:39
@dwelch-spike
Copy link
Contributor

@a-spiker For our understanding could you lay out why these changes were made? What issues were they causing?

  1. "null" changed to ""
  2. struct{}{} -> make(lib.Stats)

asconfig/generate_test.go Outdated Show resolved Hide resolved
@a-spiker
Copy link
Contributor Author

a-spiker commented Sep 12, 2024

@a-spiker For our understanding could you lay out why these changes were made? What issues were they causing?

  1. struct{}{} -> make(lib.Stats)

There is an existing test case which was failing, which expects dis to be of lib.Stats. Ideally all the sub configs should be instance of lib.Stats for consistent parsing.. It was changed here https://github.com/aerospike/aerospike-management-lib/pull/40/files#diff-3e8a272f186a1070104d40c5f775480b3f913489b147098e3662f7eda1cf8f1cR1149 . if the dc values is empty it was still going to have Len > 0 for the split.

  1. "null" changed to ""

As per the review, I have changed the expected values rather than test generated values.

cc @dwelch-spike @jdogmcsteezy

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanmayja tanmayja merged commit b2b0505 into master Sep 13, 2024
5 checks passed
@a-spiker a-spiker deleted the fix-asconfig-unit branch September 13, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants