Skip to content

Commit

Permalink
feat: add server 7.1 configs to conf parsing tables (#50)
Browse files Browse the repository at this point in the history
* Add server 7.1 configs to conf parsing tables

* Fix: Tools-2887 remove config fields from generated config that have "null" or "undefined" values. (#51)

* Add indexes-memory-budget to config parsing tables
  • Loading branch information
dwelch-spike authored Apr 24, 2024
1 parent 2bc07a8 commit 9712e2b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion asconfig/generate.go
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ func (s *transformKeyValuesStep) execute(conf Conf) error {
}

if undefinedOrNull(value) {
value = ""
continue
}

if isTypedSection(key) {
Expand Down
9 changes: 6 additions & 3 deletions asconfig/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -740,15 +740,17 @@ func isNodeSpecificContext(key string) bool {
func isSizeOrTime(key string) (bool, humanize) {
switch key {
case "default-ttl", "max-ttl", "tomb-raider-eligible-age",
"tomb-raider-period", "nsup-period", "migrate-fill-delay":
"tomb-raider-period", "nsup-period", "migrate-fill-delay",
"tls-refresh-period":
return true, deHumanizeTime

case "memory-size", "filesize", "write-block-size",
"partition-tree-sprigs", "max-write-cache",
"mounts-size-limit", "index-stage-size",
"stop-writes-count", "stop-writes-size",
"mounts-budget", "data-size",
"quarantine-allocations":
"quarantine-allocations", "flush-size",
"post-write-cache", "indexes-memory-budget":
return true, deHumanizeSize

default:
Expand Down Expand Up @@ -842,7 +844,8 @@ func isStringField(key string) bool {
"cert-file", "user-query-pattern", "key-file-password", "protocol", "vault-path",
"user-dn-pattern", "scheduler-mode", "token-hash-method",
"remote-namespace", "tls-ca-file", "role-query-base-dn", "set-enable-xdr",
"secrets-tls-context", "secrets-uds-path", "secrets-address-port":
"secrets-tls-context", "secrets-uds-path", "secrets-address-port",
"default-password-file":
return true
}

Expand Down

0 comments on commit 9712e2b

Please sign in to comment.