New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TOOLS-2984 update outdated hist info cmd from latencies #324

Closed

a-spiker wants to merge 1 commit into master from TOOLS-2984

Contributor

a-spiker commented Dec 27, 2024 •

edited

Loading

asadm runs following when run show latencies

"latencies:" -> this covers
- "latencies:hist={namespace}-read"
- "latencies:hist={namespace}-write"
- "latencies:hist={namespace}-udf"
- "latencies:hist={namespace}-batch_sub_read"
- "latencies:hist={namespace}-batch_sub_write"
- "latencies:hist={namespace}-batch_sub_udf"
- "latencies:hist={namespace}-pi_query"
- "latencies:hist={namespace}-si_query"

& Runs following when run show latencies -v

"latencies:"
"latencies:hist={namespace}-proxy"
"latencies:hist={namespace}-benchmark-fabric" INVALID COMMAND - doesn't exist on namespace level
"latencies:hist={namespace}-benchmarks-ops-sub"
"latencies:hist={namespace}-benchmarks-read"
"latencies:hist={namespace}-benchmarks-write"
"latencies:hist={namespace}-benchmarks-udf"
"latencies:hist={namespace}-benchmarks-udf-sub"
"latencies:hist={namespace}-benchmarks-batch-sub"

So Added following to the histograms removed {namespace}-benchmark-fabric & added missing histograms at namespace level

"latencies:hist={namespace}-read-touch"
"latencies:hist={namespace}-re-repl"

{ns}-read-touch was introduced in 7.1 and thus, if asadm is run against older version, it handles errors from the server for bad hist names.


          fix: TOOLS-2984 update outdated hist info cmd from latencies

391adfb

a-spiker closed this

Contributor Author

a-spiker commented Jan 3, 2025

"latencies:hist={namespace}-read-touch"
"latencies:hist={namespace}-re-repl"

are auto enabled ans should be part of "latencies:"

a-spiker deleted the TOOLS-2984 branch

January 3, 2025 10:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet