Skip to content

Commit

Permalink
fix:TOOLS-2984 removed {namespace} from benchmarks-fabric in latencies (
Browse files Browse the repository at this point in the history
#326)

* fix: benchmarks-fabric isn't at the namespace level
  • Loading branch information
a-spiker authored Jan 6, 2025
1 parent 4a5e5a1 commit 40bc361
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion lib/live_cluster/client/node.py
Original file line number Diff line number Diff line change
Expand Up @@ -2067,7 +2067,6 @@ async def info_latencies(
return data
micro_benchmarks = [
"proxy",
"benchmark-fabric",
"benchmarks-ops-sub",
"benchmarks-read",
"benchmarks-write",
Expand All @@ -2080,6 +2079,9 @@ async def info_latencies(
for ns in namespaces
for optional in micro_benchmarks
]

# TOOLS-2984: benchmarks-fabric is not at namespace-level
cmd_latencies.append("latencies:hist=benchmarks-fabric")

hist_info = []
for cmd in cmd_latencies:
Expand Down
2 changes: 1 addition & 1 deletion test/unit/live_cluster/client/test_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -1747,7 +1747,7 @@ async def test_info_latencies_verbose(self):
self.info_mock.assert_any_call("latencies:", self.ip)
self.info_mock.assert_any_call("latencies:hist={test}-proxy", self.ip)
self.info_mock.assert_any_call(
"latencies:hist={test}-benchmark-fabric", self.ip
"latencies:hist=benchmarks-fabric", self.ip
)
self.info_mock.assert_any_call(
"latencies:hist={test}-benchmarks-ops-sub", self.ip
Expand Down

0 comments on commit 40bc361

Please sign in to comment.