Skip to content

Commit

Permalink
chore!: TOOLS-2875 remove generate config command in favor of ascon…
Browse files Browse the repository at this point in the history
…fig (#271)

* chore!: TOOLS-2875 remove `generate config` command in favor of asconfig
  • Loading branch information
Jesse S authored Apr 4, 2024
1 parent 7a85ea6 commit 2411e82
Show file tree
Hide file tree
Showing 9 changed files with 5 additions and 2,163 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
submodules: true
- name: Get Python version from Pipfile
run: echo "PYTHON_VERSION=$(grep "python_full_version" Pipfile | cut -d ' ' -f 3 - | tr -d '"')" >> $GITHUB_ENV
- name: Set up Python ${{ env.PYTHON_VERSION }}
Expand Down
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ bundled with asadm version 2.6 and later.
### Build and Install Asadm
1. Install python 3.10
2. Install [pipenv](https://pypi.org/project/pipenv/)
3. Build Asadm
3. Initialize submodules `git submodule update --init`
4. Build Asadm
- There are two ways asadm can be bundled: one-file and one-dir. Both, are related to
pyinstaller's two methods of bundling. The one-file build is great if you want a single
executable artifact. The downside of one-file is that it must decompress into a /tmp
Expand All @@ -41,7 +42,7 @@ bundled with asadm version 2.6 and later.
```
make one-file
```
4. Install asadm
5. Install asadm
```
sudo make install
```
Expand Down
1 change: 0 additions & 1 deletion lib/live_cluster/collectinfo_controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import traceback
from typing import Any, Callable
from lib.live_cluster.client.node import Node
from lib.live_cluster.generate_config_controller import GenerateConfigController
from lib.live_cluster.logfile_downloader import LogFileDownloader
from lib.live_cluster import ssh
from lib.utils.types import NodeDict
Expand Down
100 changes: 0 additions & 100 deletions lib/live_cluster/generate_config_controller.py

This file was deleted.

4 changes: 0 additions & 4 deletions lib/live_cluster/live_cluster_root_controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
import asyncio
from io import StringIO
import sys
from lib.live_cluster.generate_config_controller import (
GenerateController,
)

from OpenSSL import SSL
from lib.live_cluster.collectlogs_controller import CollectlogsController
Expand Down Expand Up @@ -85,7 +82,6 @@ async def __init__(

self.controller_map = {
"health": HealthCheckController,
"generate": GenerateController,
"summary": SummaryController,
"features": FeaturesController,
"pager": PagerController,
Expand Down
Loading

0 comments on commit 2411e82

Please sign in to comment.