Schools #641
Open
Schools #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
- Coverage 81.31% 81.06% -0.26%
==========================================
Files 129 134 +5
Lines 10013 10318 +305
==========================================
+ Hits 8142 8364 +222
- Misses 1871 1954 +83 ☔ View full report in Codecov by Sentry. |
Daihecyy
reviewed
Dec 23, 2024
armanddidierjean
requested changes
Dec 25, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
armanddidierjean
requested changes
Jan 2, 2025
armanddidierjean
requested changes
Jan 2, 2025
Daihecyy
approved these changes
Jan 5, 2025
foucblg
pushed a commit
that referenced
this pull request
Jan 6, 2025
> [!IMPORTANT] > We really need to release new versions **soon**, as we have not for several months and there's some time needed to test in alpha before prod. This goes hand in hand with the **major version bump** [for Titan](../../Titan/pull/462). Both PRs are ready, and _seemingly_ waiting for some more **breaking changes** to be merged, including (by likelihood): - [ ] Allow students from other Schools to have a MyECL account: #641 - [ ] MyECLPay: #611 - [ ] "_Centrale Mega Meme_" Meme module: [no PR yet] [see branch](../tree/cmm) - [x] External Notifications: #613
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
armanddidierjean
requested changes
Jan 10, 2025
| db_school = models_core.CoreSchool( | ||
| id=school.value, | ||
| name=school.name, | ||
| email_regex=".*", |
There was a problem hiding this comment.
We should probably set a regex
| initialization.create_school_sync(school=db_school, db=db) | ||
| except IntegrityError as error: | ||
| hyperion_error_logger.fatal( | ||
| f"Startup: Could not add group {db_school.name}<{db_school.id}> in the database: {error}", |
There was a problem hiding this comment.
Suggested change
| f"Startup: Could not add group {db_school.name}<{db_school.id}> in the database: {error}", | |
| f"Startup: Could not add school {db_school.name}<{db_school.id}> in the database: {error}", |
Comment on lines
+132
to
+133
| name: Mapped[str] = mapped_column(String, unique=True) | ||
| email_regex: Mapped[str] = mapped_column(String) |
There was a problem hiding this comment.
Suggested change
| name: Mapped[str] = mapped_column(String, unique=True) | |
| email_regex: Mapped[str] = mapped_column(String) | |
| name: Mapped[str] = mapped_column(unique=True) | |
| email_regex: Mapped[str] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist