Greencode module #429
Greencode module #429
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
==========================================
+ Coverage 82.74% 82.95% +0.21%
==========================================
Files 97 101 +4
Lines 6078 6259 +181
==========================================
+ Hits 5029 5192 +163
- Misses 1049 1067 +18 ☔ View full report in Codecov by Sentry. |
guillaumetavernier
added
enhancement
| status_code=201, | ||
| ) | ||
| async def create_item( | ||
| item: schemas_greencode.ItemBase, |
There was a problem hiding this comment.
You should probably check the qr_code_content does not already exist
| "/greencode/item/{item_id}", | ||
| status_code=204, | ||
| ) | ||
| async def update_advertiser( |
There was a problem hiding this comment.
You should probably check the qr_code_content does not already exist
There was a problem hiding this comment.
Isn't it redundant with the unique=true in models ?
| ) | ||
|
|
||
| completion = schemas_greencode.Completion( | ||
| user=schemas_greencode.CoreUserSimple(**user.__dict__), |
There was a problem hiding this comment.
Is it useful to return the user, as we need to know the user_id to get this object?
There was a problem hiding this comment.
Do you suggest using different schemas for the single and list endpoints ?
On a frontend perspective, I think it would add some complexity
guillaumetavernier
force-pushed
the
greencode-module
branch
from
e363b6d to
481069a
Compare
Description
Doc : https://hedgedoc.eclair.ec-lyon.fr/CQfERrCRSuacIMpqEaPfng
Checklist