Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Jan 2024 CPU release post #2570

Merged
merged 13 commits into from
Jan 26, 2024
Merged

Conversation

smlambert
Copy link
Contributor

Description of change

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

Signed-off-by: Shelley Lambert <[email protected]>
Signed-off-by: Shelley Lambert <[email protected]>
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/65b3cca27a782b2492dbc38e
😎 Deploy Preview https://deploy-preview-2570--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@smlambert
Copy link
Contributor Author

New & Noteworthy Notes:

@smlambert
Copy link
Contributor Author

Release Notes:

Signed-off-by: Shelley Lambert <[email protected]>
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c523909) 99.27% compared to head (d670717) 99.28%.
Report is 50 commits behind head on main.

❗ Current head d670717 differs from pull request most recent head 611bf7c. Consider uploading reports for the commit 611bf7c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2570   +/-   ##
=======================================
  Coverage   99.27%   99.28%           
=======================================
  Files          87       87           
  Lines        6622     6680   +58     
  Branches      574      582    +8     
=======================================
+ Hits         6574     6632   +58     
  Misses         48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shelley Lambert <[email protected]>
Signed-off-by: Shelley Lambert <[email protected]>
@smlambert smlambert marked this pull request as ready for review January 24, 2024 23:03
@smlambert
Copy link
Contributor Author

Amalgate info from https://openjdk.org/groups/vulnerability/advisories/2024-01-16 and NIST.

@smlambert
Copy link
Contributor Author

@smlambert smlambert self-assigned this Jan 25, 2024
Signed-off-by: Shelley Lambert <[email protected]>
Signed-off-by: Shelley Lambert <[email protected]>
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments which you can take or leave, but I'm only giving this as 'request changes' because of the "Diagram X" ambiguity to make sure that's considered before this is merged. Otherwise this LGTM

Temurin 11 and 17 on AIX remain unavailable due to an [issue with Harfbuzz](https://bugs.openjdk.org/browse/JDK-8313643). Fortunately, an update to the version of Harfbuzz is targeted for April 2024.

### Refinements to SBOM Contents
As of this release, extra details relating to Windows and Mac compiler versions are being recorded in the Software Bill of Materials (SBOM) for those platforms (details can be found in temurin-build [PR 3606](https://github.com/adoptium/temurin-build/pull/3606)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As of this release, extra details relating to Windows and Mac compiler versions are being recorded in the Software Bill of Materials (SBOM) for those platforms (details can be found in temurin-build [PR 3606](https://github.com/adoptium/temurin-build/pull/3606)).
As of this release, extra details relating to Windows and Mac compiler versions are being recorded in the Software Bill of Materials (SBoM) for those platforms (details can be found in temurin-build [PR 3606](https://github.com/adoptium/temurin-build/pull/3606)).

### AIX JDK11 and JDK17 Unavailable
Temurin 11 and 17 on AIX remain unavailable due to an [issue with Harfbuzz](https://bugs.openjdk.org/browse/JDK-8313643). Fortunately, an update to the version of Harfbuzz is targeted for April 2024.

### Refinements to SBOM Contents
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SBoM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I 've seen it represented that way, always see it referenced as SBOM (including at NIST glossary).


## New and Noteworthy

### Dropping Temurin ARM 32bit Linux binaries for JDK 21 and up
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Dropping Temurin ARM 32bit Linux binaries for JDK 21 and up
### Dropping Temurin Arm 32bit Linux binaries for JDK 21 and up

## New and Noteworthy

### Dropping Temurin ARM 32bit Linux binaries for JDK 21 and up
As per the Eclipse Adoptium PMC decision (minuted here), the project will not produce Temurin binaries for ARM 32bit Linux for JDK 21 and up. This decision is based on several criteria, including download statistics, level of support for the platform in the upstream OpenJDK project and interest from Adoptium Working Group members.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As per the Eclipse Adoptium PMC decision (minuted here), the project will not produce Temurin binaries for ARM 32bit Linux for JDK 21 and up. This decision is based on several criteria, including download statistics, level of support for the platform in the upstream OpenJDK project and interest from Adoptium Working Group members.
As per the Eclipse Adoptium PMC decision (minuted here), the project will not produce Temurin binaries for Arm 32-bit Linux for JDK 21 and up. This decision is based on several criteria, including download statistics, level of support for the platform in the upstream OpenJDK project and interest from Adoptium Working Group members.

Now that we have created pipelines that verify the Temurin binaries we produce are reproducible, we have an effective way to confirm that this 'feature' does not regress. As per Diagram X, for all primary platforms on JDK 21.0.2+13, we confirm those binaries are reproducible.

### SLSA Level 3 for Majority of platforms
Since our previous release, we have been diligently been working at closing the last issues required for us to declare [SLSA Level 3 compliance for Linux and macOS Temurin binaries](https://adoptium.net/blog/2024/01/slsabuild3-temurin/). This is a lauded accomplishment for the project, though our work is on-going. Our 2024 plan sees us continue to focus on secure development best practices.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Since our previous release, we have been diligently been working at closing the last issues required for us to declare [SLSA Level 3 compliance for Linux and macOS Temurin binaries](https://adoptium.net/blog/2024/01/slsabuild3-temurin/). This is a lauded accomplishment for the project, though our work is on-going. Our 2024 plan sees us continue to focus on secure development best practices.
Since our previous release, we have been diligently been working at closing the last issues required for us to declare [SLSA Level 3 compliance for Linux and macOS Temurin binaries](https://adoptium.net/blog/2024/01/slsabuild3-temurin/). This is a lauded accomplishment for the project, though our work is ongoing. Our 2024 plan sees us continue to focus on secure development best practices.

As of this release, extra details relating to Windows and Mac compiler versions are being recorded in the Software Bill of Materials (SBOM) for those platforms (details can be found in temurin-build [PR 3606](https://github.com/adoptium/temurin-build/pull/3606)).

### Confirmation of Reproducible Builds for JDK 21 Temurin binaries
Now that we have created pipelines that verify the Temurin binaries we produce are reproducible, we have an effective way to confirm that this 'feature' does not regress. As per Diagram X, for all primary platforms on JDK 21.0.2+13, we confirm those binaries are reproducible.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume "Diagram X" is intended to be replaced by something here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will be pushing an additional file shortly and updating this reference, thanks!

Signed-off-by: Shelley Lambert <[email protected]>
Signed-off-by: Shelley Lambert <[email protected]>
Signed-off-by: Shelley Lambert <[email protected]>
Signed-off-by: Shelley Lambert <[email protected]>
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

@jerboaa
Copy link
Contributor

jerboaa commented Jan 25, 2024

There are some linter errors, though.

Signed-off-by: Shelley Lambert <[email protected]>
Signed-off-by: Shelley Lambert <[email protected]>
@smlambert
Copy link
Contributor Author

Linter errors fixed, not sure I understand the CI / code cov failure or if it is specific to this PR or a general problem, ReferenceError: jest is not defined.

@smlambert
Copy link
Contributor Author

smlambert commented Jan 25, 2024

Raised #2624 since CI failure appears to affect all PRs in this repo, not related to this one specifically.

@smlambert smlambert enabled auto-merge (squash) January 26, 2024 13:47
@smlambert smlambert disabled auto-merge January 26, 2024 13:47
@xavierfacq xavierfacq merged commit ac93d29 into adoptium:main Jan 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants