Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation support to navbar #2432

Merged

Conversation

xavierfacq
Copy link
Member

Add translation support to NavBar component + Translation in French 🇫🇷

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

Copy link

netlify bot commented Nov 10, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 8df4be0
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/654df0afc541ac00084fee6a
😎 Deploy Preview https://deploy-preview-2432--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xavierfacq xavierfacq changed the title Add tranlation support to navbar Add translation support to navbar Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2432 (8df4be0) into main (3010e27) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2432   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          87       87           
  Lines        6542     6542           
  Branches      552      552           
=======================================
  Hits         6490     6490           
  Misses         52       52           
Files Coverage Δ
src/components/NavBar/index.tsx 97.58% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@xavierfacq xavierfacq enabled auto-merge (squash) November 10, 2023 09:04
@xavierfacq xavierfacq merged commit ef80ca7 into adoptium:main Nov 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants