Pg12 #8
Open
Pg12 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| WHEN p.prorettype = 'pg_catalog.trigger'::pg_catalog.regtype THEN 'trigger' | ||
| ELSE 'normal' | ||
| END as "type", | ||
| CASE p.prokind |
There was a problem hiding this comment.
PG 11 made it a pain by renaming pro kind, since pg10 is still out there and supported until 2022 we might want to retain compatibility. I'd execute different SQLs depending on whether current_setting('server_version_num')::integer > 110000
There was a problem hiding this comment.
I guess we should focus for now making dumbo usable for adjust.
Making it usable for a broader audience could be the next step.
|
LGTM (due to relaxing of dependency versions I had no issues with either installing it or installing dependencies/using rake with adjust/pg-country#13). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.